From owner-svn-src-head@freebsd.org Sat Apr 20 12:51:07 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 439DD158D42C; Sat, 20 Apr 2019 12:51:07 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DC04890145; Sat, 20 Apr 2019 12:51:06 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id B2BE5E449; Sat, 20 Apr 2019 12:51:06 +0000 (UTC) (envelope-from asomers@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id x3KCp6fU044900; Sat, 20 Apr 2019 12:51:06 GMT (envelope-from asomers@FreeBSD.org) Received: (from asomers@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id x3KCp6it044898; Sat, 20 Apr 2019 12:51:06 GMT (envelope-from asomers@FreeBSD.org) Message-Id: <201904201251.x3KCp6it044898@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: asomers set sender to asomers@FreeBSD.org using -f From: Alan Somers Date: Sat, 20 Apr 2019 12:51:06 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r346441 - in head/sys/modules: em fusefs iavf X-SVN-Group: head X-SVN-Commit-Author: asomers X-SVN-Commit-Paths: in head/sys/modules: em fusefs iavf X-SVN-Commit-Revision: 346441 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DC04890145 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.98 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.98)[-0.985,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Apr 2019 12:51:07 -0000 Author: asomers Date: Sat Apr 20 12:51:05 2019 New Revision: 346441 URL: https://svnweb.freebsd.org/changeset/base/346441 Log: Use symlinks for kernel modules rather than hardlinks When aliasing a kernel module to a different name (ie if_igb for if_em), it's better to use symlinks than hard links. kldxref will omit entries for the links, ensuring that the loaded module has the correct name. Reviewed by: imp MFC after: 2 weeks Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D19979 Modified: head/sys/modules/em/Makefile head/sys/modules/fusefs/Makefile head/sys/modules/iavf/Makefile Modified: head/sys/modules/em/Makefile ============================================================================== --- head/sys/modules/em/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/em/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -22,6 +22,6 @@ CFLAGS += -I${SRCTOP}/sys/dev/e1000 # DEVICE_POLLING for a non-interrupt-driven method #CFLAGS += -DDEVICE_POLLING -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/if_igb.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/if_igb.ko .include Modified: head/sys/modules/fusefs/Makefile ============================================================================== --- head/sys/modules/fusefs/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/fusefs/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -8,6 +8,6 @@ SRCS= vnode_if.h \ fuse_vfsops.c fuse_vnops.c fuse_internal.c fuse_main.c # Symlink for backwards compatibility with systems installed at 12.0 or older -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/fuse.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/fuse.ko .include Modified: head/sys/modules/iavf/Makefile ============================================================================== --- head/sys/modules/iavf/Makefile Sat Apr 20 11:34:53 2019 (r346440) +++ head/sys/modules/iavf/Makefile Sat Apr 20 12:51:05 2019 (r346441) @@ -15,6 +15,6 @@ SRCS += i40e_common.c i40e_nvm.c i40e_adminq.c # Enable asserts and other debugging facilities # CFLAGS += -DINVARIANTS -DINVARIANTS_SUPPORT -DWITNESS -LINKS= ${KMODDIR}/${KMOD}.ko ${KMODDIR}/if_ixlv.ko +SYMLINKS= ${KMOD}.ko ${KMODDIR}/if_ixlv.ko .include