From owner-freebsd-current@freebsd.org Thu Nov 19 21:08:34 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7117A33BD3 for ; Thu, 19 Nov 2015 21:08:34 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from mail.ignoranthack.me (ignoranthack.me [199.102.79.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AD45B1334; Thu, 19 Nov 2015 21:08:34 +0000 (UTC) (envelope-from sbruno@freebsd.org) Received: from [192.168.1.38] (unknown [104.254.64.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sbruno@ignoranthack.me) by mail.ignoranthack.me (Postfix) with ESMTPSA id 805AC1928D7; Thu, 19 Nov 2015 21:08:32 +0000 (UTC) Subject: Re: sys/modules "make clean" seems broken again To: John Baldwin , freebsd-current@freebsd.org References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx> Cc: 'Warner Losh' From: Sean Bruno Message-ID: <564E3A50.40600@freebsd.org> Date: Thu, 19 Nov 2015 13:08:32 -0800 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <3514235.7QMnNNElsE@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 21:08:34 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 11/19/15 10:12, John Baldwin wrote: > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: >> I thought I fixed this a year or two ago, but now a "make clean" >> in sys/modules seems to leave bus_if.h device_if.h and pci_if.h >> in the directory. >> >> Should I just add these to the clean targets? > > Blame Warner as his MFILES changes broke this. In particular, see > r287263 which turned off cleaning these up. I'm not sure what that > broke that caused it to be disabled. > > Your change is a gross hack though. > Definitely. Just committing that would be pretty bad. There's similar code above it that I used as a template for this change. I'm not sure that its any less gross ... :-( sean -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAEBCgBmBQJWTjpQXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRCQUFENDYzMkU3MTIxREU4RDIwOTk3REQx MjAxRUZDQTFFNzI3RTY0AAoJEBIB78oecn5k5AsH/2z3H/jFttevRnWKKP9C4DUM qkZKz3KjvQHDmlGXjPsfsAJQO7ngsoleGnFCFipRzk2ICmhfJQFcKYeSyUJVvRiO 91MkcQHEzmy4bOdLNbAKj5b9R/WtFwOdY3HwPyiI1tnxRTovnT2gJ5Qg0u6oNFdw RAFMrn9hMMYxcHRGjJyfOdXP0fYpb752oAlJR1cL3lpsh6MqZfqhDCZShimnveht R71BTUqQu3X4YdeXt4CRWFqwGchQD0J0T/wFp0JqA5oM2uK1JxenHqz/5mNzuQol X8xjrhN/Bh5sLK+QFsdBcmlbQ6aEsy7Dq8Abm7tWz46TCO1qcp1SgU+7Ny1+9eY= =f5LD -----END PGP SIGNATURE-----