From owner-svn-src-all@FreeBSD.ORG Thu Mar 31 20:16:12 2011 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 93F3B106564A; Thu, 31 Mar 2011 20:16:12 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 2CC3C8FC13; Thu, 31 Mar 2011 20:16:12 +0000 (UTC) Received: from [10.30.101.54] ([209.117.142.2]) (authenticated bits=0) by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p2VKCxMe011231 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO); Thu, 31 Mar 2011 14:13:01 -0600 (MDT) (envelope-from imp@bsdimp.com) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Warner Losh In-Reply-To: <201103311558.50709.jhb@freebsd.org> Date: Thu, 31 Mar 2011 14:12:54 -0600 Content-Transfer-Encoding: quoted-printable Message-Id: <4DEF8A5E-6ADE-4B27-8E1C-82188DB1244D@bsdimp.com> References: <201103310807.p2V87DHV096049@svn.freebsd.org> <201103310740.20265.jhb@freebsd.org> <73CB36BD-1C9E-4992-A3C7-B540ABB7F11E@bsdimp.com> <201103311558.50709.jhb@freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.1082) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (harmony.bsdimp.com [10.0.0.6]); Thu, 31 Mar 2011 14:13:02 -0600 (MDT) Cc: svn-src-head@FreeBSD.org, Adrian Chadd , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r220185 - in head/sys: amd64/conf arm/conf conf dev/ath i386/conf mips/conf modules modules/ath modules/ath_ahb modules/ath_pci pc98/conf sparc64/conf X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2011 20:16:12 -0000 On Mar 31, 2011, at 1:58 PM, John Baldwin wrote: > On Thursday, March 31, 2011 3:29:11 pm Warner Losh wrote: >>=20 >> On Mar 31, 2011, at 5:40 AM, John Baldwin wrote: >>=20 >>> On Thursday, March 31, 2011 4:07:13 am Adrian Chadd wrote: >>>> Author: adrian >>>> Date: Thu Mar 31 08:07:13 2011 >>>> New Revision: 220185 >>>> URL: http://svn.freebsd.org/changeset/base/220185 >>>>=20 >>>> Log: >>>> Break out the ath PCI logic into a separate device/module. >>>>=20 >>>> Introduce the AHB glue for Atheros embedded systems. Right now it's >>>> hard-coded for the AR9130 chip whose support isn't yet in this HAL; >>>> it'll be added in a subsequent commit. >>>>=20 >>>> Kernel configuration files now need both 'ath' and 'ath_pci' = devices; both >>>> modules need to be loaded for the ath device to work. >>>=20 >>> Err, there's no need to break the kernel config. Just have the = kernel DTRT if=20 >>> both ath and pci are enabled using something like: >>>=20 >>> sys/dev/ath/if_ath_pci.c ath pci >>>=20 >>> in sys/conf/files. >>>=20 >>> You can still have an if_ath_pci.ko module with this arrangement. = This is=20 >>> what almost all other drivers due that have multiple bus backends. >>=20 >> Well, most drivers with multiple back ends compile all the relevant = ones for the platform in. There's very few that call out individual = ones (ata=20 > and its kin being the big exception). >=20 > Yes, that is true for modules, and I agree that the module build for = if_ath.ko > should just include all the relevant bus attachments for each = platform. >=20 > There's certainly no reason to not use the method above for = sys/conf/files > and remove 'device ath_pci', etc. Agreed. Wasn't trying to disagree with you there. Warner=