From owner-freebsd-gnome@FreeBSD.ORG  Sat Jan  3 10:24:34 2004
Return-Path: <owner-freebsd-gnome@FreeBSD.ORG>
Delivered-To: freebsd-gnome@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1BFBD16A4CE; Sat,  3 Jan 2004 10:24:34 -0800 (PST)
Received: from lakemtao06.cox.net (lakemtao06.cox.net [68.1.17.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 711FE43D1D; Sat,  3 Jan 2004 10:24:32 -0800 (PST)
	(envelope-from mezz7@cox.net)
Received: from mezz.mezzweb.com ([68.103.32.11]) by lakemtao06.cox.net
          (InterMail vM.5.01.06.05 201-253-122-130-105-20030824) with ESMTP
          id <20040103182432.UYAU24575.lakemtao06.cox.net@mezz.mezzweb.com>;
          Sat, 3 Jan 2004 13:24:32 -0500
Date: Sat, 03 Jan 2004 12:23:31 -0600
To: freebsd-gnats-submit@FreeBSD.org, amistry@am-productions.biz,
	edwin@FreeBSD.org
From: Jeremy Messenger <mezz7@cox.net>
Content-Type: text/plain; format=flowed; charset=iso-8859-1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Message-ID: <opr07pdhkh8ckrg5@smtp.central.cox.net>
User-Agent: Opera7.23/Linux M2 build 518
cc: gnome@freebsd.org
Subject: Re: ports/59496: New Port: x11/gtk-smooth-engine
X-BeenThere: freebsd-gnome@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: GNOME for FreeBSD -- porting and maintaining
	<freebsd-gnome.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-gnome>
List-Post: <mailto:freebsd-gnome@freebsd.org>
List-Help: <mailto:freebsd-gnome-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-gnome>,
	<mailto:freebsd-gnome-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 03 Jan 2004 18:24:34 -0000

This one does really need to clean, so here's my feedback.

	- The CATEGORIES needs to be change to 'x11-toolkits gnome',
	  just check 'ls /usr/ports/x11-toolkits | grep gtk' to see how many
	  gtk themes are in there. Which meaning, you should move this
	  port from x11 to x11-toolkits.

	- Need to add the 'CONFLICT= gnome-themes-extras-*',
	  because the x11-toolkits/gnome-themes-extras has the smooth
	  engine in there.

	- Need to use the USE_GNOME= gtk12 and USE_GNOME=gtk20
	  instead full path to the library. [1]

	- Need to use the ${HAVE_GNOME:Mgtk12} instead find the
	  the full path library to have the WITH_GTK12=yes. Same as with
	  gtk20. You can check some examples from mplayer, AbiWord2,
	  vim and etc. [1]

	- I disagree with the SHLIB, I do not think it's need for this. Well,
	  if you still prefer to have this then nevermind about this until
	  someone disagree.

	- Remove the 'USE_GNOME= gtk12 gtk20', which they should
	  be inside the HAVE_GNOME or WITH_* as I have said above.

	- Might need to use .include <bsd.port.pre.mk> and
	  .include <bsd.port.post.mk>.

	- Remove the '@dirrm lib/gtk-2.0/2.2.0/engines' in the pkg-plist,
	  because this directory is belong to GTK; not any theme engine.

	- Please use the portlint, the test is failed.

Hope, it helps.

[1] To learn more about them how to create the gtk/gnome port, visit: 
http://www.freebsd.org/gnome/docs/porting.html

BTW: I am CC'ing to gnome@freebsd.org , in case if I am missing something 
else or I am wrong.

Cheers,
Mezz


-- 
bsdforums.org 's moderator, mezz.