From owner-svn-ports-head@freebsd.org Tue Mar 16 02:19:09 2021 Return-Path: Delivered-To: svn-ports-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 93F72573D53; Tue, 16 Mar 2021 02:19:09 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dzxms3nyMz4qvB; Tue, 16 Mar 2021 02:19:09 +0000 (UTC) (envelope-from danfe@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615861149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPjWvFsIob7FFgdT+3irm/P/jWzjX/nC8WVVOcB5JbE=; b=a9NCxRJivfukZ388bt7QzoCe8NrqqgyOxY5G5cNYE5l4oXLCXzH4lQgwTdnlVT+dfshkzt jf0mDnBCgDegF9mBQ4D+XigSDXHYcDAdBCZ8KD54w/asj6pY/F91SI5BsRSbiRnY9TdXvi qdeyIdzsKNMsJEJopmPXGeAbzyI/P3MHlyaPSqn1fFQheI4iMIOmi1u9Z6+OkGf+8LwrlK 7n1R9nfBQqIUK526sViksO1Y4Qq2JYHhIrKXH9zFH7BBwKMrRBvQ4oRu4lIzeQW9sNoghA hRa3gqtgCJFwuGS7gyNYsX5IVUm8KXdqOiHbE3HMjPB/RAvVlghusRIP6viZdQ== Received: by freefall.freebsd.org (Postfix, from userid 1033) id 69239EBEF; Tue, 16 Mar 2021 02:19:09 +0000 (UTC) Date: Tue, 16 Mar 2021 02:19:09 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Cc: Adriaan de Groot , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r566508 - in head: Mk/Uses devel/qt5-core devel/qt5/files Message-ID: <20210316021909.GB21936@FreeBSD.org> References: <202102242045.11OKjEpT075754@repo.freebsd.org> <20210225091804.qip5ehkragajibmg@aching.in.mat.cc> <20210225093513.GA59@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210225093513.GA59@FreeBSD.org> ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1615861149; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=sPjWvFsIob7FFgdT+3irm/P/jWzjX/nC8WVVOcB5JbE=; b=VD/UcNUFqZ0FFxyr0IuzMtW3T7fftUp7aNuXIGSfYA9ZlpkeSfdhRK4ryFsIubFCtDWUSH 4mun9Eklwo8moKqWY4kzrG32xGM0fpEoYwr6bQ03CAUDWO8ICpWVblIAn+6Lg2ZIocTQTf 87AfobnY9LT9mHxmADKBRdb5d9sPu1/0YwIaMNoLUuBo5Or7n7ADtmyjNWCrDy8IHOv1Cx WrZr3Jf+ZFTSi/thN3OXhjEzKYtsbcikGSU/VOeBVrIZ+1Jup+OKr/ABR/4LAwsnVPP2QB fAfOwevk+HR/AQ1x4XxsSwwzFaMne2xnqxfZ/tlIAXNP/FoOnZDWVkkFrsQkcg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1615861149; a=rsa-sha256; cv=none; b=YUWevKXy2t4aX+VUWYi5MTiQ6+yyN2pW2RonDvDi6Yu+1z+S3v1VlKWA96VXlqyHhkzeXK GNe6FXqIjlxN+STn5sru93lppC2vLavuz3e+dzshzfCZDzYvWExjKQSBLVp7ebv4cxZX2G wElF3WQ1nfh7KQvL1XpbXcdub4GQv7jQ9Olr2Cfy3fwvzm71e0V/rYIB2dtTIlaYyN6J12 DNbJUJR4a4+vxBHB+bdg4IMHxlhDtTYAAxu3iEchysL58r1NaeUFhAwcE5ZoF6OVYoPMT/ WWkSlgrlhq+YBRnoeYpUFO9J42nQuEyfXCdYhC1uFxSm/rMSOqkA38VUbmUt2w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Mar 2021 02:19:09 -0000 On Thu, Feb 25, 2021 at 09:35:13AM +0000, Alexey Dokuchaev wrote: > On Thu, Feb 25, 2021 at 10:18:04AM +0100, Mathieu Arnold wrote: > > On Wed, Feb 24, 2021 at 08:45:14PM +0000, Adriaan de Groot wrote: > > > - @${REINPLACE_CMD} 's/\t//g' ${PKGINSTALL} ${PKGDEINSTALL} > > > + # Drop all leading spaces in the script, to minify > > > + @${REINPLACE_CMD} 's/^ *//' ${PKGINSTALL} ${PKGDEINSTALL} > > > > [[:space:]] works with all versions. > > Yes please. Not just it's more robust, it also expresses the intention > better, as we probably want to trim *any* unnecessary whitespace, not > some particular character. So, anything prevents us from going the [[:blank:]] way? ./danfe