From owner-cvs-all Fri Jan 11 14:22:43 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id C8BC137B417; Fri, 11 Jan 2002 14:22:39 -0800 (PST) Received: (from iedowse@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g0BMMdh66532; Fri, 11 Jan 2002 14:22:39 -0800 (PST) (envelope-from iedowse) Message-Id: <200201112222.g0BMMdh66532@freefall.freebsd.org> From: Ian Dowse Date: Fri, 11 Jan 2002 14:22:39 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfsserver nfsm_subs.h X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG iedowse 2002/01/11 14:22:39 PST Modified files: sys/nfsserver nfsm_subs.h Log: The macro nfsm_reply() is supposed to allocate a reply in all cases, but since the nfs cleanup, it hasn't done so in the case where `error' is EBADRPC. Callers of this macro expect it to initialise *mrq, and the `nfsmout' exit point expects a reply to be allocated if error == 0. When nfsm_reply() was called with error = EBADRPC, whatever junk was in *mrq (often a stale pointer to an old reply mbuf) would be assumed to be a valid reply and passed to pru_sosend(), causing a crash sooner or later. Fix this by allocating a reply even in the EBADRPC case like we used to do. This bug was specific to -current. Revision Changes Path 1.33 +2 -2 src/sys/nfsserver/nfsm_subs.h To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message