From owner-freebsd-gnome@FreeBSD.ORG Tue Apr 22 07:20:26 2008 Return-Path: Delivered-To: gnome@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 668C3106564A for ; Tue, 22 Apr 2008 07:20:26 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.delphij.net (delphij-pt.tunnel.tserv2.fmt.ipv6.he.net [IPv6:2001:470:1f03:2c9::2]) by mx1.freebsd.org (Postfix) with ESMTP id B8FB78FC17 for ; Tue, 22 Apr 2008 07:20:24 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [202.108.54.204]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.delphij.net (Postfix) with ESMTPS id 3D87F28449 for ; Tue, 22 Apr 2008 15:20:17 +0800 (CST) Received: from localhost (tarsier.geekcn.org [202.108.54.204]) by tarsier.geekcn.org (Postfix) with ESMTP id 899B3EB4BF8; Tue, 22 Apr 2008 15:20:14 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([202.108.54.204]) by localhost (mail.geekcn.org [202.108.54.204]) (amavisd-new, port 10024) with ESMTP id ZGx4rQtJOjQh; Tue, 22 Apr 2008 15:20:05 +0800 (CST) Received: from charlie.delphij.net (c-69-181-135-56.hsd1.ca.comcast.net [69.181.135.56]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id 4743CEB40F5; Tue, 22 Apr 2008 15:20:02 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=qent8RE4L6BoEol8KdHv4MoVft+tMdhwrTgygQy1EWnqO3OQwqBCAIPdeQBm+avO6 A0+b9RPqUER78ivlP4q9Q== Message-ID: <480D919D.50500@delphij.net> Date: Tue, 22 Apr 2008 00:19:57 -0700 From: Xin LI Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080421) MIME-Version: 1.0 To: Jeremy Messenger References: <480D6CEC.5030007@delphij.net> <1208841455.87116.11.camel@shumai.marcuscom.com> In-Reply-To: X-Enigmail-Version: 0.95.6 OpenPGP: id=18EDEBA0; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: gnome@freebsd.org, d@delphij.net Subject: Re: Can someone review this? [Fwd: Re: ports/122975: [PATCH] Fix for mail/thunderbird SIGFPE crash on FreeBSD/amd64] X-BeenThere: freebsd-gnome@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: GNOME for FreeBSD -- porting and maintaining List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Apr 2008 07:20:26 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Jeremy Messenger wrote: | On Tue, 22 Apr 2008 00:17:35 -0500, Joe Marcus Clarke | wrote: | |> On Mon, 2008-04-21 at 21:43 -0700, Xin LI wrote: | ATT. This fixes a very nasty issue which prevents me from being able to | use enigmime-thunderbird. |>> |>> Approved. | |> Do other gecko ports need same change in Double.cpp? | |> # find /usr/ports -name patch-Double.cpp |> /usr/ports/mail/lightning/files/patch-Double.cpp |> /usr/ports/mail/thunderbird/files/patch-Double.cpp |> /usr/ports/www/firefox/files/patch-Double.cpp |> /usr/ports/www/firefox15/files/patch-Double.cpp |> /usr/ports/www/flock/files/patch-Double.cpp |> /usr/ports/www/mozilla/files/patch-Double.cpp I think so but we really need to check it in a case-by-case basis (I can do this when I have some spare time, but will really appreciate if someone who uses these everyday to provide a hand :). To make a long story short, it seems that the floating number implementation of the javascript engine uses some hackish magic which will raise upperflow exception on, at least, FreeBSD/i386 and amd64. Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkgNkZ0ACgkQi+vbBBjt66Bz2wCbBPnWmFuVBR8huG+QchDtCq58 T6oAoKALA0MePIlN5PSFMLc4hGevxpnM =GATO -----END PGP SIGNATURE-----