From nobody Wed Dec 13 22:21:07 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Sr91H49CJz54PW7 for ; Wed, 13 Dec 2023 22:21:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Sr91H2Bsyz3RYs for ; Wed, 13 Dec 2023 22:21:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1702506067; a=rsa-sha256; cv=none; b=iw20W1ft7kJqMUuFPGh5jsv58sM3Mk1SWlqYEMAFIPZ6MEf1hwWX7oKqoJZcLH38O6VCCv 51jl5890PYePE6WdlEazPFcCHHmj94f5hP2KE3UHWuVehxNUNXRW8xd4ymCRF2rQcQgOW4 28w1OqUWOB3IZp71/MdsCpKx1VdAGXJ3k481Pfhltbk6Ng6hgc9EC7o/Nz0WvXN9nOj8X5 6kzbnQEQLzLPDBG5EEKGcHG1KSo0ZYpPR3Snx/U98yzPRmrRep/U8Y+BcV7jmzVHuz4RSn cd/Wut18+QchiRcA9F896P95oeT+6lsgZdSphI/X3YztpKKEBZm/96boLuUVzQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1702506067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vva1NsbDImjckB8F0qawJZLhpXlcDfkx3NkSR8cDUWs=; b=l/T/2AofqWobnvt+CW1sBMCG9BszvtRdqCMBK3Wj/SL1zy21ifZoVPeI/cx4EDRgb9ihH4 gqoC/nw/e/ORwpgP3F/AE5zTDkXmw/pFkbEj2IBphCjmz4944DfIEUt7rgCLNEmIYGBIy7 VHTdjO8H3MdLB3L48cLHsJ2zsWFkQ3GQeZbpQ++zZwaQaaHfBDv7mB+cCunwStr0SdKmqi J2kbFWECSuHdOd4qScRyrFkQMje63FJ+2XohEzTGnalwUNdyHelcF3Dc1HQtwILK2C0AO1 uL3sI4zCHV/W/S7Zn7tGKAxY9yntawc9qWs1acK7qarthtXr0DbdBjMAimfoZw== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Sr91H1Fpmz1G6g for ; Wed, 13 Dec 2023 22:21:07 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 3BDML7cl019608 for ; Wed, 13 Dec 2023 22:21:07 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 3BDML73f019607 for bugs@FreeBSD.org; Wed, 13 Dec 2023 22:21:07 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 275741] sys/modules: Fix processing of WITHOUT_MODULES Date: Wed, 13 Dec 2023 22:21:07 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: freebsd@kumba.dev X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: attachments.isobsolete attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D275741 Joshua Kinard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #247024|0 |1 is obsolete| | --- Comment #2 from Joshua Kinard --- Created attachment 247035 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D247035&action= =3Dedit Fix processing of WITHOUT_MODULES v2 This version of the patch fixes an accidental bug in the kmod.without.mk for loop where I was trying to be too clever and compare `basename CURDIR` agai= nst `dirname kmod` to try and limit accidental matches from being removed from SUBDIR. A.k.a., being overly-cautious and while that check works for a sin= gle subdirectory level (foo/bar), it fails if the kmod name in WITHOUT_MODULES = has several subdirectory levels (foo/bar/baz). After adding better debugging a= nd looking through the build log, the conditional simply isn't needed, so it is removed in this version. Also updated the date in the make.conf.5 man page. --=20 You are receiving this mail because: You are the assignee for the bug.=