From owner-freebsd-commit Tue Mar 28 02:25:56 1995 Return-Path: commit-owner Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA06369 for commit-outgoing; Tue, 28 Mar 1995 02:25:56 -0800 Received: (from majordom@localhost) by freefall.cdrom.com (8.6.10/8.6.6) id CAA06356 for cvs-lib-outgoing; Tue, 28 Mar 1995 02:25:53 -0800 Received: from time.cdrom.com (time.cdrom.com [192.216.223.46]) by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id CAA06350; Tue, 28 Mar 1995 02:25:51 -0800 Received: from freefall.cdrom.com (freefall.cdrom.com [192.216.222.4]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id CAA18676; Tue, 28 Mar 1995 02:25:48 -0800 Received: from localhost (localhost [127.0.0.1]) by freefall.cdrom.com (8.6.10/8.6.6) with SMTP id CAA06299; Tue, 28 Mar 1995 02:23:10 -0800 X-Authentication-Warning: freefall.cdrom.com: Host localhost didn't use HELO protocol To: Bruce Evans cc: CVS-commiters@time.cdrom.com, cvs-lib@time.cdrom.com, jkh@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdlib strhash.c In-reply-to: Your message of "Tue, 28 Mar 95 20:05:49 +1000." <199503281005.UAA18620@godzilla.zeta.org.au> Date: Tue, 28 Mar 1995 02:23:10 -0800 Message-ID: <6298.796386190@freefall.cdrom.com> From: "Jordan K. Hubbard" Sender: commit-owner@freebsd.org Precedence: bulk > You never needed to rename hash() to _hash(). It is static so it doesn't > contribute to namespace pollution. Adding a leading underscore just moves > it into the implementation's namespace and might cause problems if the Well, then we have a problem because the friggin' thing DOES clash when you try to link anything with it otherwise! :-( :-( Give it a try. Perhaps Nate should look into this too, since it's possibly something suspicious with the new ld stuff. > be distinguished from names in the `barhash' module by prefixing them with > `foo'. `strhash' is a bad name for a module because names starting with > `str' are reserved. Well, again, I was just trying to avoid clashing with the existing hash stuff. I'd be more than happy to rename it to hash.c, but when I had it that way originally it clashed with db/hash.c's include of hash.h and I didn't want to rename the header and not the implementation file - that would have been even more confusing. I'll concur that the name strhash was rather deeply uninspired, but I didn't expect the clash in the first place and when it happened I was rather desperate to fix things again quickly. Suggestions? Jordan