From owner-freebsd-mips@FreeBSD.ORG  Sat Feb  6 12:00:16 2010
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 26FB710657D3
	for <freebsd-mips@freebsd.org>; Sat,  6 Feb 2010 12:00:16 +0000 (UTC)
	(envelope-from rrs@lakerest.net)
Received: from lakerest.net (unknown [IPv6:2001:240:585:2:213:d4ff:fef3:2d8d])
	by mx1.freebsd.org (Postfix) with ESMTP id F35638FC17
	for <freebsd-mips@freebsd.org>; Sat,  6 Feb 2010 12:00:13 +0000 (UTC)
Received: from [10.1.1.53] ([10.1.1.53]) (authenticated bits=0)
	by lakerest.net (8.14.3/8.14.3) with ESMTP id o16C0ANm048802
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT);
	Sat, 6 Feb 2010 07:00:10 -0500 (EST) (envelope-from rrs@lakerest.net)
Message-Id: <670383AE-410B-4590-B054-B56A7E5A09A4@lakerest.net>
From: Randall Stewart <rrs@lakerest.net>
To: Neel Natu <neelnatu@gmail.com>
In-Reply-To: <dffe84831002052149w6d3afd1re0f5dbca4e5a9a20@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Date: Sat, 6 Feb 2010 04:00:09 -0800
References: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com>
	<20100205.200134.460114267490858629.imp@bsdimp.com>
	<dffe84831002052149w6d3afd1re0f5dbca4e5a9a20@mail.gmail.com>
X-Mailer: Apple Mail (2.936)
Cc: freebsd-mips@freebsd.org
Subject: Re: Patch: SMP support for MIPS
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 06 Feb 2010 12:00:16 -0000

Neel/Warner:

I won't have time to look at these until I get back to
California ... actually I will look at them on
the plane tomorrow ;-)

R
On Feb 5, 2010, at 9:49 PM, Neel Natu wrote:

> Hi Warner,
>
> Thanks for looking at this.
>
> On Fri, Feb 5, 2010 at 7:01 PM, M. Warner Losh <imp@bsdimp.com> wrote:
>> In message: <dffe84831002051827r430c7fb6le3c3506bd6d38a03@mail.gmail.com 
>> >
>>            Neel Natu <neelnatu@gmail.com> writes:
>> : I have put the diff here for review:
>> : http://people.freebsd.org/~neel/mips_smp_patch/diff.txt
>>
>> + /*
>> +  * XXX
>> +   * SMP kernels must delay pcpu initialization until after
>> +    * TLB has been flushed and initialized (see mips_cpu_init())
>> +     */
>> +     if (pcpu_find(0) == NULL)
>> +        mips_pcpu0_init();
>> +
>>
>> The practical upshot of this change is that panic() prior to this
>> point will fault.  Is there some way to avoid this?
>>
>
> That's right. I have this fixed in the updated patch. Please review
> the changes to pmap.c and machdep.c.
> http://people.freebsd.org/~neel/mips_smp_patch/diff.txt
>
> Briefly, we use an address in KSEG0 for the 'pcpup' until we are ready
> to transition to a TLB-based pcpu pointer.
>
>> The rest of these changes look fairly good.  I'll likely comment on a
>> few nits later that I saw once I have the time to devote to it.
>>
>
> Ok.
>
> best
> Neel
>
>> Warner
>>
> _______________________________________________
> freebsd-mips@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-mips
> To unsubscribe, send any mail to "freebsd-mips- 
> unsubscribe@freebsd.org"
>

------------------------------
Randall Stewart
803-317-4952 (cell)
803-345-0391(direct)