From owner-freebsd-hackers@FreeBSD.ORG Tue Oct 19 19:22:45 2010 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18F5B1065672; Tue, 19 Oct 2010 19:22:45 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id DE2AC8FC14; Tue, 19 Oct 2010 19:22:44 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 791FC46BA5; Tue, 19 Oct 2010 15:22:44 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 676508A009; Tue, 19 Oct 2010 15:22:43 -0400 (EDT) From: John Baldwin To: Alexander Best Date: Tue, 19 Oct 2010 15:22:21 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <20101018235318.GA87158@freebsd.org> <201010191103.50986.jhb@freebsd.org> <20101019191446.GA44841@freebsd.org> In-Reply-To: <20101019191446.GA44841@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201010191522.21357.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Tue, 19 Oct 2010 15:22:43 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: freebsd-hackers@freebsd.org, Matthew Jacob Subject: Re: SCSI_DELAY cleanup X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Oct 2010 19:22:45 -0000 On Tuesday, October 19, 2010 3:14:46 pm Alexander Best wrote: > On Tue Oct 19 10, John Baldwin wrote: > > On Tuesday, October 19, 2010 10:31:10 am Alexander Best wrote: > > > On Tue Oct 19 10, Matthew Jacob wrote: > > > > It would be an effective behavioral change for those of us who remove > > > > that line. > > > > Personally, I think 5 seconds is too long- even 2 seconds is more than > > > > adequate even for moderately old 'other' hardware like scanners. > > > > > > > > For -current, why don't you simply remove all of the config lines and > > > > leave the default at 2000ms? > > > > > > hmmm...i can only test the delay value on amd64. i was under the impression > > > that archs like arm and mips need the longer delay. > > > > > > also at some locations in the code SCSI_DELAY is being set to 15000. i believe > > > this is the case when certain drivers (cam, ahb, aha) get loaded as a kernel > > > module, but i'm not sure. it looks like this: > > > > > > .if !defined(KERNBUILDDIR) > > > opt_scsi.h: > > > echo "#define SCSI_DELAY 15000" > ${.TARGET} > > > .endif > > > > I believe this is all old history. SCSI_DELAY used to be set to 15000 in > > GENERIC many years ago and was lowered to 5000. Most likely these Makefiles > > were simply not updated at the time. > > oh i see. maybe this revised patch would be better suited then. I think so, but you should post this to scsi@ for the best review. -- John Baldwin