From owner-svn-ports-head@FreeBSD.ORG Thu Dec 18 12:00:45 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 17A01F77; Thu, 18 Dec 2014 12:00:45 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D34801958; Thu, 18 Dec 2014 12:00:44 +0000 (UTC) Received: from [192.168.1.12] (ip70-178-7-237.ks.ks.cox.net [70.178.7.237]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 43E0E435C7; Thu, 18 Dec 2014 06:00:25 -0600 (CST) Message-ID: <5492C1C8.6020308@marino.st> Date: Thu, 18 Dec 2014 13:00:08 +0100 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Baptiste Daroussin , Bryan Drewery Subject: Re: svn commit: r374800 - head/Mk/Uses References: <201412161206.sBGC6fa5045717@svn.freebsd.org> <54902709.9090801@marino.st> <71EBD6FD6D89266B6651554A@ogg.in.absolight.net> <20141216133802.GA27647@ravenloft.kiev.ua> <5B209A4BD7689CD74744CFA7@ogg.in.absolight.net> <20141216141320.GA28332@ravenloft.kiev.ua> <20141216142422.GA38033@FreeBSD.org> <5490DFDB.5080000@FreeBSD.org> <20141218111154.GA21894@ivaldir.etoilebsd.net> In-Reply-To: <20141218111154.GA21894@ivaldir.etoilebsd.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , svn-ports-all@freebsd.org, ports-committers@freebsd.org, Mathieu Arnold , Alex Kozlov X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Dec 2014 12:00:45 -0000 On 12/18/2014 12:11, Baptiste Daroussin wrote: > On Tue, Dec 16, 2014 at 07:43:55PM -0600, Bryan Drewery wrote: >> On 12/16/2014 8:24 AM, Alexey Dokuchaev wrote: >>> On Tue, Dec 16, 2014 at 04:13:20PM +0200, Alex Kozlov wrote: >>>> On Tue, Dec 16, 2014 at 02:47:09PM +0100, Mathieu Arnold wrote: >>>>> +--On 16 d'ecembre 2014 15:38:02 +0200 Alex Kozlov wrote: >>>>> | Allow me to ask, why it should be 8 and not 4? >>>>> >>>>> Because a tabulation is 8 spaces. It should be consistent over the whole >>>>> ports tree. >>>> >>>> Well, 'Please view me with 4 column tabs!' line was added to bsd.port.mk >>>> more than 20 year ago, in rev 69, because it's inconvenient to view it with >>>> default tabulation value: many wrapped lines, indentation too deep, etc. >>> >>> I think I agree with Alex here. While most of us prefer ts=8, I don't see >>> the need to reindent some files, most notably b.p.m., as it will completely >>> jeopardize its history and make 'svn blame' basically useless. >>> >>> Even with editors that cannot grok ex:ts=X hints, its not that hard to do it >>> manually every time you need to view/edit these files. I do it all the time >>> with nvi(1). >>> >>> ./danfe >>> >> >> As a vendor who maintains a forked ports tree, I despise this commit and >> all of the ones below. It makes carrying out customizations very >> difficult. Yes, it doesn't *look* good on the eyes, but reindenting on >> such large files with large history maintained by > 1 person is a sin. >> >> > Wow that makes impressive to quote that whole list of commits, among those > changes a few are really changing things more than a few comments, and most of > which are files that are either removed and/or heavily worked on at the time, > there are yes 1 or 2 maybe controversial here but that is all. > I'm a bit disappointed that "svn blame" output is considered more important than doing the right thing, myself. It's a tool, not a constitutional by-law. Just fix all the Mk files at once. John