From owner-cvs-all@FreeBSD.ORG Sun Oct 5 00:16:45 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EC28016A4B3; Sun, 5 Oct 2003 00:16:45 -0700 (PDT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 82E4143F85; Sun, 5 Oct 2003 00:16:45 -0700 (PDT) (envelope-from jeff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.9/8.12.9) with ESMTP id h957GjXJ078639; Sun, 5 Oct 2003 00:16:45 -0700 (PDT) (envelope-from jeff@repoman.freebsd.org) Received: (from jeff@localhost) by repoman.freebsd.org (8.12.9/8.12.9/Submit) id h957GjfA078638; Sun, 5 Oct 2003 00:16:45 -0700 (PDT) (envelope-from jeff) Message-Id: <200310050716.h957GjfA078638@repoman.freebsd.org> From: Jeff Roberson Date: Sun, 5 Oct 2003 00:16:45 -0700 (PDT) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/ufs/ffs ffs_vfsops.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2003 07:16:46 -0000 jeff 2003/10/05 00:16:45 PDT FreeBSD src repository Modified files: sys/ufs/ffs ffs_vfsops.c Log: - Check the XLOCK before inspecting v_data. - Slightly rewrite the fsync loop to be more lock friendly. We must acquire the vnode interlock before dropping the mnt lock. We must also check XLOCK to prevent vclean() races. - Use LK_INTERLOCK in the vget() in ffs_sync to further prevent vclean() races. - Use a local variable to store the results of the nvp == TAILQ_NEXT test so that we do not access the vp after we've vrele()d it. - Add an XXX comment about UFS_UPDATE() not being protected by any lock here. I suspect that it should need the VOP lock. Revision Changes Path 1.218 +25 -9 src/sys/ufs/ffs/ffs_vfsops.c