From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 22 23:03:00 2005 Return-Path: X-Original-To: freebsd-ports-bugs@FreeBSD.org Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4335A16A420 for ; Tue, 22 Nov 2005 23:03:00 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from hood.oook.cz (hood.oook.cz [195.250.137.134]) by mx1.FreeBSD.org (Postfix) with ESMTP id 66E3D43D9C for ; Tue, 22 Nov 2005 23:02:58 +0000 (GMT) (envelope-from pav@FreeBSD.org) Received: from ikaros.oook.cz (localhost [127.0.0.1]) by hood.oook.cz (8.13.4/8.13.4) with ESMTP id jAMN2ux1011927 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Nov 2005 00:02:56 +0100 (CET) (envelope-from pav@FreeBSD.org) Received: (from pav@localhost) by ikaros.oook.cz (8.13.4/8.13.4/Submit) id jAMN2uNa011926; Wed, 23 Nov 2005 00:02:56 +0100 (CET) (envelope-from pav@FreeBSD.org) X-Authentication-Warning: ikaros.oook.cz: pav set sender to pav@FreeBSD.org using -f From: Pav Lucistnik To: Ion-Mihai Tetcu In-Reply-To: <20051123005108.14ffff2e@it.buh.tecnik93.com> References: <200511222220.jAMMK1bB012364@freefall.freebsd.org> <20051123003447.7046be7d@it.buh.tecnik93.com> <1132699378.47320.12.camel@localhost> <20051123005108.14ffff2e@it.buh.tecnik93.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-DwIvBOtbcmuFCIXSABGR" Date: Wed, 23 Nov 2005 00:02:55 +0100 Message-Id: <1132700575.47320.16.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.4.1 FreeBSD GNOME Team Port Cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/89300: [MAINTAINER] multimedia/bsdav: remove BROKEN X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pav@FreeBSD.org List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 23:03:00 -0000 --=-DwIvBOtbcmuFCIXSABGR Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Ion-Mihai Tetcu p=ED=B9e v st 23. 11. 2005 v 00:51 +0200: > On Tue, 22 Nov 2005 23:42:58 +0100 > Pav Lucistnik wrote: >=20 > > Ion-Mihai Tetcu p=ED=B9e v st 23. 11. 2005 v 00:34 +0200: > > > On Tue, 22 Nov 2005 22:20:01 GMT > > > Pav Lucistnik wrote: > > >=20 > > > > Synopsis: [MAINTAINER] multimedia/bsdav: remove BROKEN > > > >=20 > > > > State-Changed-From-To: open->closed > > > > State-Changed-By: pav > > > > State-Changed-When: Tue Nov 22 22:19:30 GMT 2005 > > > > State-Changed-Why:=20 > > > > Committed with fixes. Next time, what about running portlint(1)? > > >=20 > > > What was wrong ? ``^^'' =3D my comments > > >=20 > > > root@it> /usr/ports/multimedia/bsdav.my [0:32:16] 0 > > > # portlint -A > >=20 > > You should be running either `portlint -AN' for new ports or `portlint > > -C' for updates ... >=20 > Still, what was the problem ? I wanna learn, not make you loose time, you > know :) >=20 > root@it> /usr/ports/multimedia/bsdav.my [0:46:11] 0 > # portlint -C > WARN: Makefile [26]: possible direct use of command "install" found. use = ${INSTALL_foobaa} instead. > ^^ false > WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_tables.c [8]: = includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import. > WARN: /usr/ports/multimedia/bsdav.my/files/patch-lib_bsdav_video_hw.c [8]= : includes possible RCS tag "$Id$". use binary mode (-ko) on commit/import. > ^^ are this two a problem ? > WARN: no CVS directories. Use -N to check a new port. > ^^ 'casue I've copied the port in bsdav.my; in the PR is OK (bsdav) > 0 fatal errors and 4 warnings found. I got different output. You're using latest and greatest portlint 2.8.0? I got the IGNORE capitalization message. Anyway, my changes: First, you don't raise PORTREVISION on change that don't affect package. Second, your IGNORE string does not make any sense when used. I fixed that. Third, you used OPTIONS incorrectly. I fixed that. For details, see chapter in PH. --=20 Pav Lucistnik It whines, glows and fades... --=-DwIvBOtbcmuFCIXSABGR Content-Type: application/pgp-signature; name=signature.asc Content-Description: Toto je =?iso-8859-2?Q?digit=E1ln=EC?= =?ISO-8859-1?Q?_podepsan=E1?= =?iso-8859-2?Q?_=E8=E1st?= =?ISO-8859-1?Q?_zpr=E1vy?= -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQBDg6OfntdYP8FOsoIRAoWRAKCXg2KGxKJq0WGhMOC/mS4BiCch7ACfbxX9 z4conUoGjk4D0YuzOPS2Rp4= =bLmF -----END PGP SIGNATURE----- --=-DwIvBOtbcmuFCIXSABGR--