From owner-p4-projects@FreeBSD.ORG  Mon Mar 20 15:25:47 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 89F3F16A423; Mon, 20 Mar 2006 15:25:47 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6793916A41F
	for <perforce@freebsd.org>; Mon, 20 Mar 2006 15:25:47 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3114D43D45
	for <perforce@freebsd.org>; Mon, 20 Mar 2006 15:25:47 +0000 (GMT)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k2KFPlp2012913
	for <perforce@freebsd.org>; Mon, 20 Mar 2006 15:25:47 GMT
	(envelope-from millert@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k2KFPkaO012910
	for perforce@freebsd.org; Mon, 20 Mar 2006 15:25:46 GMT
	(envelope-from millert@freebsd.org)
Date: Mon, 20 Mar 2006 15:25:46 GMT
Message-Id: <200603201525.k2KFPkaO012910@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	millert@freebsd.org using -f
From: Todd Miller <millert@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 93627 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Mar 2006 15:25:47 -0000

http://perforce.freebsd.org/chv.cgi?CH=93627

Change 93627 by millert@millert_p3 on 2006/03/20 15:25:46

	In fdcopy() set newfdp->fd_freefile after the first loop
	over fdp instead of the loop over newfdp.  This means we
	never enter fdused() with fd_freefile == -1.  It also fixes
	a bug when fdp->fd_lastfile == -1.  Previously, if
	fdp->fd_lastfile was -1 newfdp->fd_freefile would get set
	to 1 instead of 0 since newfdp->fd_lastfile is initialized
	to 0 and newfdp->fd_freefile will not have been set in the
	first loop (which doesn't run at all in this case).
	It's not clear why newfdp->fd_freefile is -1 at this point.

Affected files ...

.. //depot/projects/trustedbsd/sebsd/sys/kern/kern_descrip.c#18 edit

Differences ...

==== //depot/projects/trustedbsd/sebsd/sys/kern/kern_descrip.c#18 (text+ko) ====

@@ -1604,17 +1604,15 @@
 				newfdp->fd_freefile = i;
 		}
 	}
+	newfdp->fd_cmask = fdp->fd_cmask;
 	FILEDESC_UNLOCK_FAST(fdp);
 	FILEDESC_LOCK(newfdp);
+	if (newfdp->fd_freefile == -1)
+		newfdp->fd_freefile = i;
 	for (i = 0; i <= newfdp->fd_lastfile; ++i)
 		if (newfdp->fd_ofiles[i] != NULL)
 			fdused(newfdp, i);
 	FILEDESC_UNLOCK(newfdp);
-	FILEDESC_LOCK_FAST(fdp);
-	if (newfdp->fd_freefile == -1)
-		newfdp->fd_freefile = i;
-	newfdp->fd_cmask = fdp->fd_cmask;
-	FILEDESC_UNLOCK_FAST(fdp);
 	return (newfdp);
 }