From owner-freebsd-ports  Sat Mar 24 16:13:59 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from blizzard.sabbo.net (ns.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP id 6924E37B719
	for <ports@FreeBSD.ORG>; Sat, 24 Mar 2001 16:13:52 -0800 (PST)
	(envelope-from max@vic.sabbo.net)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f2P0DkX24475;
	Sun, 25 Mar 2001 02:13:46 +0200
Received: (from max@localhost)
	by vic.sabbo.net (8.11.3/8.11.2) id f2P0Djr06954;
	Sun, 25 Mar 2001 02:13:45 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
From: Maxim Sobolev <sobomax@FreeBSD.ORG>
Message-Id: <200103250013.f2P0Djr06954@vic.sabbo.net>
Subject: Re: Conditionalizing MACHINE_CPU checks
To: kris@obsecurity.org (Kris Kennaway)
Date: Sun, 25 Mar 2001 02:13:45 +0200 (EET)
Cc: kapr@acm.org (Alex Kapranoff), ports@FreeBSD.ORG
In-Reply-To: <20010324154609.A42192@xor.obsecurity.org> from "Kris Kennaway" at Mar 24, 2001 03:46:09 PM
X-Mailer: ELM [version 2.5 PL5]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote:
> > Good day to all.
> >=20
> > Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx})
> > inside ${OSVERSION} >=3D 500018 tests?
> 
> It's also in RELENG_4 now, so you should use check for
> 
> ${OSVERSION} >=3D 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >=3D 43=
> 0000 )
> 
> > E.g. is it ok to do tests in this way:
> >=20
> > .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx}
> > SRCS+=3D	mmx.c
> > .elif ${ARCH} =3D=3D "i386"
> > 	@${ECHO_MSG} "You can define WITH_MMX to use MMX instructions"
> > .endif
> 
> I'd prefer to keep it under an .if OSVERSION test, so it becomes
> easier to just chop out the .else section when we stop supporting
> systems older than ${OSVERSION} =3D=3D 430000

I think that the best way is to add HAVE_CPU_MK into bsd.port.mk,
so we will hot have to repeat the same OSVERSION checks in every
port.

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message