From owner-svn-src-all@freebsd.org Fri Jul 26 12:51:40 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2F494BF3D6; Fri, 26 Jul 2019 12:51:40 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.blih.net", Issuer "mail.blih.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id B37908EE56; Fri, 26 Jul 2019 12:51:38 +0000 (UTC) (envelope-from manu@bidouilliste.com) Received: from mail.blih.net (mail.blih.net [212.83.177.182]) by mail.blih.net (OpenSMTPD) with ESMTP id 0dfa1e63; Fri, 26 Jul 2019 14:51:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; s=mail; bh=ewh0iC8qZs3iP0N5iO29Lz00Qn4=; b=diytNRIsPjzFo2Mhn5Rx9mNhdMGC pp+CC6eEVMB8btzNuHT8PkNCtujlrvrXzVOxwEJVsxSaLjACK4vh/yWVSBDUiPiB tk9k4CrilkBP4tqolJTjUgVxK5ZjnzYJRyBH9n1kF2QkjU4uuX/Y8sLn14Gfyb11 TwXdxQpsoXac3vw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=bidouilliste.com; h=date :from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type:content-transfer-encoding; q=dns; s= mail; b=tYa9yTsnRBVEpJrCwPiesjc9XtKRT0RbcoGJBOcrJJxSqvCuvIttFU+/ syH94y5CCZh8zJgqBKPbTw/1UCDR5cWg2b2XTYTTePU0nk4uqzaTqlWz1tDiikIH 526NHqWTF1u+h0uuCFHnXpRNZM9mp6jbOCYdoix+HzmZ5GYwoyY= Received: from knuckles.blih.net (ip-9.net-89-3-105.rev.numericable.fr [89.3.105.9]) by mail.blih.net (OpenSMTPD) with ESMTPSA id 06d43836 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 26 Jul 2019 14:51:31 +0200 (CEST) Date: Fri, 26 Jul 2019 05:10:42 +0200 From: Emmanuel Vadot To: Guido Falsi Cc: Emmanuel Vadot , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350135 - head/share/mk Message-Id: <20190726051042.fcc4f6d969e19fb6f480977b@bidouilliste.com> In-Reply-To: <28eb9717-533e-3d87-0e30-f60317ed97cb@FreeBSD.org> References: <201907191511.x6JFBWVi053537@repo.freebsd.org> <37944eff-6e00-df14-59d3-beae3fa89b6a@FreeBSD.org> <28eb9717-533e-3d87-0e30-f60317ed97cb@FreeBSD.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; amd64-portbld-freebsd13.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B37908EE56 X-Spamd-Bar: ++ Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bidouilliste.com header.s=mail header.b=diytNRIs; spf=pass (mx1.freebsd.org: domain of manu@bidouilliste.com designates 212.83.177.182 as permitted sender) smtp.mailfrom=manu@bidouilliste.com X-Spamd-Result: default: False [2.42 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[bidouilliste.com:s=mail]; URIBL_BLOCKED(0.00)[bidouilliste.com.multi.uribl.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:212.83.177.182/32]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DMARC_NA(0.00)[bidouilliste.com]; NEURAL_SPAM_MEDIUM(0.88)[0.879,0]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_SPAM_SHORT(0.93)[0.927,0]; MX_GOOD(-0.01)[mx-backup.blih.net,mail.blih.net]; DKIM_TRACE(0.00)[bidouilliste.com:+]; NEURAL_SPAM_LONG(0.18)[0.182,0]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; IP_SCORE(0.34)[ip: (-1.00), ipnet: 212.83.160.0/19(2.62), asn: 12876(0.09), country: FR(-0.01)]; ASN(0.00)[asn:12876, ipnet:212.83.160.0/19, country:FR]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jul 2019 12:51:40 -0000 On Thu, 25 Jul 2019 00:17:31 +0200 Guido Falsi wrote: > On 25/07/19 00:14, Guido Falsi wrote: > > On 19/07/19 17:11, Emmanuel Vadot wrote: > >> Author: manu > >> Date: Fri Jul 19 15:11:32 2019 > >> New Revision: 350135 > >> URL: https://svnweb.freebsd.org/changeset/base/350135 > >> > >> Log: > >> bsd.confs.mk: Test the correct value for the destination package > >> > >> Reviewed by: bapt, gjb > >> Differential Revision: https://reviews.freebsd.org/D20961 > >> > > > > Hello, > > > > I don't know the actual workings of this file and have not checked it in > > depth, but this change is causing "make package" to not package > > /etc/rc.d/sshd (and others, all the ones being defined in > > ${group}PACKAGE variables), which are then missing when upgrading machines. > > > > Reverting this change makes packaging things work again. I think this > > change is actually wrong and the previous version was correct. > > /etc/rc.d/sshd is in the FreeBSD-sshd package, the other ones are also in their own package now, I'll check them all to see if that make sense. > After sending this message I also noticed, it causes the spurious > "FreeBSD-zfs" package to be generated again. Not so spurious, it now contains the rc.d zfs related files. I think that I'll remove it anyway, it doesn't make sense. > -- > Guido Falsi -- Emmanuel Vadot