Date: Thu, 16 Oct 2014 01:48:40 +0000 (UTC) From: Rui Paulo <rpaulo@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r273157 - head/sys/arm/arm Message-ID: <201410160148.s9G1me4Y096791@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rpaulo Date: Thu Oct 16 01:48:39 2014 New Revision: 273157 URL: https://svnweb.freebsd.org/changeset/base/273157 Log: Remove the "Unable to unwind further" message from DDB. The ARM version of DDB is supposedly reliable enough making this message benign. Modified: head/sys/arm/arm/db_trace.c Modified: head/sys/arm/arm/db_trace.c ============================================================================== --- head/sys/arm/arm/db_trace.c Thu Oct 16 01:32:22 2014 (r273156) +++ head/sys/arm/arm/db_trace.c Thu Oct 16 01:48:39 2014 (r273157) @@ -382,7 +382,7 @@ db_stack_trace_cmd(struct unwind_state * } else { /* A prel31 offset to the unwind table */ state->insn = (uint32_t *) - ((uintptr_t)&index->insn + + ((uintptr_t)&index->insn + db_expand_prel31(index->insn)); } /* Run the unwind function */ @@ -407,7 +407,7 @@ db_stack_trace_cmd(struct unwind_state * state->registers[SP], state->registers[FP]); /* Don't print the registers we have already printed */ - upd_mask = state->update_mask & + upd_mask = state->update_mask & ~((1 << SP) | (1 << FP) | (1 << LR) | (1 << PC)); sep = "\n\t"; for (i = 0, reg = 0; upd_mask != 0; upd_mask >>= 1, reg++) { @@ -421,7 +421,7 @@ db_stack_trace_cmd(struct unwind_state * i = 0; } else sep = " "; - + } } db_printf("\n"); @@ -436,7 +436,6 @@ db_stack_trace_cmd(struct unwind_state * * message (maybe it needs a STOP_UNWINDING). */ if (index->insn == EXIDX_CANTUNWIND) { - db_printf("Unable to unwind further\n"); finished = true; } else if (state->registers[PC] < VM_MIN_KERNEL_ADDRESS) { db_printf("Unable to unwind into user mode\n");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201410160148.s9G1me4Y096791>