From owner-freebsd-net@FreeBSD.ORG Thu Sep 20 08:54:52 2012 Return-Path: Delivered-To: net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0205C106566C for ; Thu, 20 Sep 2012 08:54:52 +0000 (UTC) (envelope-from andy@fud.org.nz) Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com [209.85.160.54]) by mx1.freebsd.org (Postfix) with ESMTP id C2CEE8FC14 for ; Thu, 20 Sep 2012 08:54:51 +0000 (UTC) Received: by pbbrp2 with SMTP id rp2so5034184pbb.13 for ; Thu, 20 Sep 2012 01:54:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=wcQw4k6VUHjHfZxu59QUzvcOqmwb5+WjJi00GwGLsok=; b=D28pO4WRbtAzl0VZaSVETyJ7B8iJ2KxCczCVaFnBwX0rBFJWY6vvlSE9R7xUJTd0XL xcTh3mwf1MtMEbcs9A+BYgrcgjzOsqVt7JxzdWnBVsIYcaA+EdGH84tDzF6Pb6HXPgOM UarQoNgMT+ug00udNxbGoBGgIn5OMNmxIGaFwPp+1NFyr/QE3DuFvhdFpK0dPfaZeAZR leW1V8t6X1GBvmWdT2Csyciu3ByI+sG2HVgWuawDi97ZbIK4TkLCFDTL41ep58hypj2p OP9XohrAF0T1eayjrBxn2g4BuoBrlxgILqu0LyVWB5gu7qsF3XUSQSKgTU6v8nf2QOZ6 2low== MIME-Version: 1.0 Received: by 10.68.220.137 with SMTP id pw9mr5079267pbc.1.1348131291355; Thu, 20 Sep 2012 01:54:51 -0700 (PDT) Sender: andy@fud.org.nz Received: by 10.68.29.6 with HTTP; Thu, 20 Sep 2012 01:54:51 -0700 (PDT) In-Reply-To: <20120920084804.GY85604@glebius.int.ru> References: <20120920074730.GS85604@FreeBSD.org> <20120920084804.GY85604@glebius.int.ru> Date: Thu, 20 Sep 2012 20:54:51 +1200 X-Google-Sender-Auth: JZJhiCS2GvyCB63rawxQuflYQZM Message-ID: From: Andrew Thompson To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 X-Gm-Message-State: ALoCoQlhofl1pjbjeDWpQ3Sgt8wEpBv79DnOrsbRMd8gy13cTdG7B1Fr9hc/UlusqraHNhwPkkF7 Cc: net@freebsd.org Subject: Re: [CFT] if_transmit method for lagg(4) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2012 08:54:52 -0000 On 20 September 2012 20:48, Gleb Smirnoff wrote: > Hi! > > On Thu, Sep 20, 2012 at 08:37:19PM +1200, Andrew Thompson wrote: > A> > Yet another patch to test. Was suprising to me that lagg(4), which > A> > aims at high-performance, still utilizes if_start. > A> > > A> > Attached is patch that converts lagg(4) to use if_transmit. I'd > A> > appreciate if someone who do use lagg(4) tests the patch. If anyone > A> > benchmarks lagg(4) with and w/o patch that will be most appreciated. > A> > A> Sean Bruno has already tested this patch at Yahoo, I have just been > A> delayed in committing it. There are just a few small differences so we > A> can commit one or merge. > > Also fabient@ replied to me in private with this patch :) > > Hmm, I've missed stats update. I have merge statistics updates from your patch > to mine and here it is attached. Looks good, please commit. There is just a stray `i` here +static int lagg_transmit(struct ifnet *i, struct mbuf *); Andrew