From owner-cvs-src@FreeBSD.ORG Mon Jun 26 22:46:53 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1B43016A400; Mon, 26 Jun 2006 22:46:53 +0000 (UTC) (envelope-from maxim@macomnet.ru) Received: from mp2.macomnet.net (mp2.macomnet.net [195.128.64.6]) by mx1.FreeBSD.org (Postfix) with ESMTP id 58A9143D73; Mon, 26 Jun 2006 22:46:51 +0000 (GMT) (envelope-from maxim@macomnet.ru) Received: from localhost (localhost.int.ru [127.0.0.1] (may be forged)) by mp2.macomnet.net (8.13.7/8.13.3) with ESMTP id k5QMkoIT033600; Tue, 27 Jun 2006 02:46:50 +0400 (MSD) (envelope-from maxim@macomnet.ru) Date: Tue, 27 Jun 2006 02:46:50 +0400 (MSD) From: Maxim Konovalov To: Bruce M Simpson In-Reply-To: <200605141422.k4EEMnmC056704@repoman.freebsd.org> Message-ID: <20060627015411.B30917@mp2.macomnet.net> References: <200605141422.k4EEMnmC056704@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: mlaier@FreeBSD.org, cvs-src@FreeBSD.org, dsh@vlink.ru, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.h ip_output.c ip_var.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Jun 2006 22:46:53 -0000 Hi Bruce, On Sun, 14 May 2006, 14:22-0000, Bruce M Simpson wrote: > bms 2006-05-14 14:22:49 UTC > > FreeBSD src repository > > Modified files: > sys/netinet in.h ip_output.c ip_var.h > Log: > Fix a long-standing limitation in IPv4 multicast group membership. > > By making the imo_membership array a dynamically allocated vector, > this minimizes disruption to existing IPv4 multicast code. This > change breaks the ABI for the kernel module ip_mroute.ko, and may > cause a small amount of churn for folks working on the IGMPv3 merge. > > Previously, sockets were subject to a compile-time limitation on > the number of IPv4 group memberships, which was hard-coded to 20. > The imo_membership relationship, however, is 1:1 with regards to > a tuple of multicast group address and interface address. Users who > ran routing protocols such as OSPF ran into this limitation on machines > with a large system interface tree. It seems these changes broke carp(4). Now ifconfig carp0 panics in ip_carp.c::carp_set_addr() when tries to dereference imo->imo_membership[0] when imo->imo_membership == NULL. -- Maxim Konovalov