From owner-freebsd-current@freebsd.org Tue Nov 20 19:37:50 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7A518113B98A for ; Tue, 20 Nov 2018 19:37:50 +0000 (UTC) (envelope-from bwidawsk@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 191BC7F55E for ; Tue, 20 Nov 2018 19:37:50 +0000 (UTC) (envelope-from bwidawsk@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id CD311113B987; Tue, 20 Nov 2018 19:37:49 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB850113B985; Tue, 20 Nov 2018 19:37:49 +0000 (UTC) (envelope-from bwidawsk@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 650687F553; Tue, 20 Nov 2018 19:37:49 +0000 (UTC) (envelope-from bwidawsk@freebsd.org) Received: from smtp.freebsd.org (unknown [134.134.139.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: bwidawsk) by smtp.freebsd.org (Postfix) with ESMTPSA id B049C1C10E; Tue, 20 Nov 2018 19:37:48 +0000 (UTC) (envelope-from bwidawsk@freebsd.org) Date: Tue, 20 Nov 2018 11:37:47 -0800 From: Ben Widawsky To: Jung-uk Kim Cc: Charlie Li , acpi@FreeBSD.org, current@freebsd.org, John Baldwin Subject: Re: ACPI Error: No handler for Region [ECOR] Message-ID: <20181120193608.d4hjcogjybfbvght@smtp.freebsd.org> References: <5f954581-26ab-b890-9cfd-a14598c7e9ba@FreeBSD.org> <20181120192855.lqppolymrzo2ynqk@smtp.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181120192855.lqppolymrzo2ynqk@smtp.freebsd.org> User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 191BC7F55E X-Spamd-Result: default: False [-1.11 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.88)[-0.875,0]; ASN(0.00)[asn:10310, ipnet:2001:1900:2254::/48, country:US]; NEURAL_SPAM_SHORT(0.60)[0.597,0]; NEURAL_HAM_LONG(-0.84)[-0.837,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:37:50 -0000 On 18-11-20 11:28:56, Ben Widawsky wrote: > On 18-11-20 14:09:08, Jung-uk Kim wrote: > > On 18. 11. 20., Charlie Li wrote: > > > Somewhere between r340491 and r340650, probably starting from r340595, > > > my ThinkPad W550s started spewing these messages repeatedly in the > > > system log since boot: > > > > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: No handler for Region [ECOR] > > > (0xfffff80003662300) [EmbeddedControl] (20181031/evregion-288) > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Region EmbeddedControl > > > (ID=3) has no handler (20181031/exfldio-428) > > > Nov 20 09:35:19 ardmore kernel: ACPI Error: Method parse/execution > > > failed \_SB.PCI0.LPC.EC.BAT1._BST, AE_NOT_EXIST (20181031/psparse-677) > > > > > > As a result, I am now unable to query battery information at the very > > > least. r340490 is my last built revision with this working. > > > > I am pretty sure r340644 caused the regression. > > > > https://svnweb.freebsd.org/changeset/base/340644 > > > > Jung-uk Kim > > Seems like a good bet. Could you please add the full dmesg as well as an ACPI > dump and the output of `sysctl dev.acpi_ec.` Thanks. Just for a quick eyeball, this looks suspicious. You could also try this: diff --git a/sys/dev/acpica/acpi_ec.c b/sys/dev/acpica/acpi_ec.c index a21dbc963af..5d6dba6a887 100644 --- a/sys/dev/acpica/acpi_ec.c +++ b/sys/dev/acpica/acpi_ec.c @@ -422,6 +422,7 @@ acpi_ec_probe(device_t dev) /* Store the values we got from the namespace for attach. */ acpi_set_private(dev, params); +#if 0 /* * Check for a duplicate probe. This can happen when a probe via ECDT * succeeded already. If this is a duplicate, disable this device. @@ -431,6 +432,7 @@ acpi_ec_probe(device_t dev) ret = 0; else device_disable(dev); +#endif if (buf.Pointer) AcpiOsFree(buf.Pointer); -- Ben Widawsky, Intel Open Source Technology Center