From owner-svn-ports-head@FreeBSD.ORG  Tue Dec  3 03:09:57 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 975)
 id D31746F7; Tue,  3 Dec 2013 03:09:57 +0000 (UTC)
Date: Tue, 3 Dec 2013 03:09:57 +0000
From: "Sergey A. Osokin" <osa@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Subject: Re: svn commit: r335523 - in head/www/nginx: . files
Message-ID: <20131203030957.GC93494@FreeBSD.org>
References: <201312021814.rB2IEKZc015166@svn.freebsd.org>
 <20131202191057.GB93494@FreeBSD.org>
 <58E1447598180A2EFC0BC448@atuin.in.mat.cc>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <58E1447598180A2EFC0BC448@atuin.in.mat.cc>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Dec 2013 03:09:57 -0000

On Mon, Dec 02, 2013 at 11:33:41PM +0100, Mathieu Arnold wrote:
> Hi,
> 
> +--On 2 décembre 2013 19:10:57 +0000 "Sergey A. Osokin" <osa@FreeBSD.org>
> wrote:
> | Please revert back these wrong changes ASAP.
> 
> The PR has been sitting for four and a half months. If it is wrong, you
> should have said something there, so, what exactly is wrong with them ?

Would you like to maintain www/nginx?  I'm ready to pass the maintainership to you
directly.

Again, revert back these changes.

--
Sergey A. Osokin
osa@FreeBSD.org

> Regards,
> 
> | On Mon, Dec 02, 2013 at 06:14:20PM +0000, Mathieu Arnold wrote:
> |> Author: mat
> |> Date: Mon Dec  2 18:14:19 2013
> |> New Revision: 335523
> |> URL: http://svnweb.freebsd.org/changeset/ports/335523
> |> 
> |> Log:
> |>   The patch for adding syslog support sets the wrong define variable
> |>   causing syslog support to not be built.
> |>   
> |>   maintainer timeout.
> |>   
> |>   PR:		ports/180639
> |>   Submitted by:	Dave Duchscher
> |> 
> |> Modified:
> |>   head/www/nginx/Makefile
> |>   head/www/nginx/files/extra-patch-syslog_support
> |> 
> |> Modified: head/www/nginx/Makefile
> |> ========================================================================
> |> ====== --- head/www/nginx/Makefile	Mon Dec  2 18:08:41 2013	(r335522)
> |> +++ head/www/nginx/Makefile	Mon Dec  2 18:14:19 2013	(r335523)
> |> @@ -3,6 +3,7 @@
> |>  
> |>  PORTNAME=	nginx
> |>  PORTVERSION=	1.4.4
> |> +PORTREVISION=	1
> |>  PORTEPOCH=	1
> |>  CATEGORIES=	www
> |>  MASTER_SITES=	http://nginx.org/download/
> |> 
> |> Modified: head/www/nginx/files/extra-patch-syslog_support
> |> ========================================================================
> |> ====== --- head/www/nginx/files/extra-patch-syslog_support	Mon Dec  2
> |> 18:08:41 2013	(r335522) +++
> |> head/www/nginx/files/extra-patch-syslog_support	Mon Dec  2 18:14:19 2013
> |> 	(r335523) @@ -721,7 +721,7 @@ index 54e1c26..2b05157 100644
> |>  +    SYSLOG_FACILITY="LOG_DAEMON"
> |>  +fi
> |>  +if test "${USE_SYSLOG}" = "YES"; then
> |> -+    CFLAGS="$CFLAGS -DUSE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}"
> |> ++    CFLAGS="$CFLAGS -DNGX_ENABLE_SYSLOG
> |> -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" +fi
> |>   
> |>   cat << END                                                     >
> |>   $NGX_MAKEFILE
> | 
> 
> 
> 
> -- 
> Mathieu Arnold