From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Aug 17 06:30:10 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D428106566B for ; Fri, 17 Aug 2012 06:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 058A58FC12 for ; Fri, 17 Aug 2012 06:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q7H6U9Ol075310 for ; Fri, 17 Aug 2012 06:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q7H6U9S7075308; Fri, 17 Aug 2012 06:30:09 GMT (envelope-from gnats) Resent-Date: Fri, 17 Aug 2012 06:30:09 GMT Resent-Message-Id: <201208170630.q7H6U9S7075308@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Loganaden Velvindron Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 333C2106566B for ; Fri, 17 Aug 2012 06:20:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 1DF158FC0C for ; Fri, 17 Aug 2012 06:20:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q7H6KEYd053782 for ; Fri, 17 Aug 2012 06:20:14 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q7H6KEDR053781; Fri, 17 Aug 2012 06:20:14 GMT (envelope-from nobody) Message-Id: <201208170620.q7H6KEDR053781@red.freebsd.org> Date: Fri, 17 Aug 2012 06:20:14 GMT From: Loganaden Velvindron To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/170692: Incomplete perl module dependency causes password not to update correctly X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Aug 2012 06:30:10 -0000 >Number: 170692 >Category: ports >Synopsis: Incomplete perl module dependency causes password not to update correctly >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Aug 17 06:30:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Loganaden Velvindron >Release: 9.0 >Organization: Afrinic Ltd >Environment: FreeBSD ops01.mu.afrinic.net 9.0-RELEASE FreeBSD 9.0-RELEASE #0: Tue Jan 3 07:46:30 UTC 2012 root@farrell.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Daniel Shaw (daniel@afrinic.net) discovered that usermin couldn't find a dependency to change the password, in change password menu. The dependancy is p5-IO-Tty which is called by changepasswd.cgi. sub pty_process_exec { local ($cmd, $uid, $gid) = @_; if (&is_readonly_mode()) { # When in readonly mode, don't run the command $cmd = "/bin/true"; } &webmin_debug_log('CMD', "cmd=$cmd uid=$uid gid=$gid") if ($gconfig{'debug_what_cmd'}); eval "use IO::Pty"; if (!$@) { # Use the IO::Pty perl module if installed local $ptyfh = new IO::Pty; if (!$ptyfh) { pty_process_exec is later called in changepasswd.cgi: ($fh, $fpid) = &proc::pty_process_exec( $passwd_cmd, $uinfo[2], $uinfo[3]); >How-To-Repeat: Go to change password, and change an existing user password. Nothing is displayed on the web page & the password isn't updated silently either. >Fix: A workaround is to install p5-IO-Tty manually, and then the password is changed correctly and the webpage confirms the change. Patch attached with submission follows: --- Makefile.orig 2012-08-17 10:02:14.000000000 +0400 +++ Makefile 2012-08-17 09:57:36.000000000 +0400 @@ -19,6 +19,7 @@ MAINTAINER= olgeni@FreeBSD.org COMMENT= Web-based interface for performing some user tasks RUN_DEPENDS= p5-Net-SSLeay>=0:${PORTSDIR}/security/p5-Net-SSLeay \ + p5-IO-Tty>=0:${PORTSDIR}/devel/p5-IO-Tty \ p5-Authen-PAM>=0:${PORTSDIR}/security/p5-Authen-PAM FETCH_CMD?= /usr/bin/fetch -pRr >Release-Note: >Audit-Trail: >Unformatted: