Date: Tue, 3 Dec 2013 03:09:57 +0000 From: "Sergey A. Osokin" <osa@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r335523 - in head/www/nginx: . files Message-ID: <20131203030957.GC93494@FreeBSD.org> In-Reply-To: <58E1447598180A2EFC0BC448@atuin.in.mat.cc> References: <201312021814.rB2IEKZc015166@svn.freebsd.org> <20131202191057.GB93494@FreeBSD.org> <58E1447598180A2EFC0BC448@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 02, 2013 at 11:33:41PM +0100, Mathieu Arnold wrote: > Hi, > > +--On 2 décembre 2013 19:10:57 +0000 "Sergey A. Osokin" <osa@FreeBSD.org> > wrote: > | Please revert back these wrong changes ASAP. > > The PR has been sitting for four and a half months. If it is wrong, you > should have said something there, so, what exactly is wrong with them ? Would you like to maintain www/nginx? I'm ready to pass the maintainership to you directly. Again, revert back these changes. -- Sergey A. Osokin osa@FreeBSD.org > Regards, > > | On Mon, Dec 02, 2013 at 06:14:20PM +0000, Mathieu Arnold wrote: > |> Author: mat > |> Date: Mon Dec 2 18:14:19 2013 > |> New Revision: 335523 > |> URL: http://svnweb.freebsd.org/changeset/ports/335523 > |> > |> Log: > |> The patch for adding syslog support sets the wrong define variable > |> causing syslog support to not be built. > |> > |> maintainer timeout. > |> > |> PR: ports/180639 > |> Submitted by: Dave Duchscher > |> > |> Modified: > |> head/www/nginx/Makefile > |> head/www/nginx/files/extra-patch-syslog_support > |> > |> Modified: head/www/nginx/Makefile > |> ======================================================================== > |> ====== --- head/www/nginx/Makefile Mon Dec 2 18:08:41 2013 (r335522) > |> +++ head/www/nginx/Makefile Mon Dec 2 18:14:19 2013 (r335523) > |> @@ -3,6 +3,7 @@ > |> > |> PORTNAME= nginx > |> PORTVERSION= 1.4.4 > |> +PORTREVISION= 1 > |> PORTEPOCH= 1 > |> CATEGORIES= www > |> MASTER_SITES= http://nginx.org/download/ > |> > |> Modified: head/www/nginx/files/extra-patch-syslog_support > |> ======================================================================== > |> ====== --- head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 > |> 18:08:41 2013 (r335522) +++ > |> head/www/nginx/files/extra-patch-syslog_support Mon Dec 2 18:14:19 2013 > |> (r335523) @@ -721,7 +721,7 @@ index 54e1c26..2b05157 100644 > |> + SYSLOG_FACILITY="LOG_DAEMON" > |> +fi > |> +if test "${USE_SYSLOG}" = "YES"; then > |> -+ CFLAGS="$CFLAGS -DUSE_SYSLOG -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" > |> ++ CFLAGS="$CFLAGS -DNGX_ENABLE_SYSLOG > |> -DSYSLOG_FACILITY=${SYSLOG_FACILITY}" +fi > |> > |> cat << END > > |> $NGX_MAKEFILE > | > > > > -- > Mathieu Arnold
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131203030957.GC93494>