From owner-svn-src-all@freebsd.org Sat Sep 9 19:52:00 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BEC1CE05E57 for ; Sat, 9 Sep 2017 19:52:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 7A7F776463 for ; Sat, 9 Sep 2017 19:52:00 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x232.google.com with SMTP id n69so10207456ioi.5 for ; Sat, 09 Sep 2017 12:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=d2Wt00sfBtf+6b6akBJ1SMqwbyYBG7haa9gl1MibHkI=; b=mNhpY3izKUVE/0nPp4cEcWWf7R+0A5c4GtNQ9DUdPEFimEOGPkP0SbuODjzY4EG114 KoQyTBXhVTCdfiuFaRSMi9oVnEB2PXulDuv5ianvUG/iPYvx5+UBb2xuflhbU3OmHj/0 iOWlRDpW0u/GEfbsMhhaukpiNp9rxGp/pt3SjF8gG17BpT9GcZfqxWvsO5MbJhM/ZMSf 3Kj5shkWYnY4tx87t+rjFNc4D+B5RFr/y8MKyoUKVN+r11ZexmCthCCxkGfh3Key+u17 1U7+5XYdPgRd+GOWA0xbSPNlVDgsvSSiYiLm/Xa392pVYgDCNwxLJkZjTI6qdVkbzfOk h0ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=d2Wt00sfBtf+6b6akBJ1SMqwbyYBG7haa9gl1MibHkI=; b=JRHIv3sxOjoKOY1TbL1x7fVEg+rHZvRz8vUKc6a8bAdlJwgh3D76YUWt3YS644cEUQ cya9mxCpHEb53S2AljwVYr91b2bkKqQywlKS/P/3UqQnV/JdY3pAIRfa9kBCTya1jbz+ d3vDe6SSaiAhnFyzsyDuQ+yWf0menaEDWWGO1MM1nyJ2ER0PDh3ci2860Zm3vR8ElouX QRTUXZELUxgECdYBZSV0onBSzItYqjbXU2JbBqc9mHyARmaoyargVzQ7C8V6+FxK2XyT MdeHVvk1JWc8iiC4/r/cQFeCcp09SUqZNNt+1Z/lvCIWLDCk0bG0HKWuD/+uekvrfQ0P 8LDA== X-Gm-Message-State: AHPjjUhOVeoqM39nXyP60e3KGhwtsA5gTxaO5ZTGkSO0T6RUgjSNA+Bh BE0Crus4pdZG+fYTxW6eqf+EfexcJCZR X-Google-Smtp-Source: AOwi7QAZbHVQi5fwLw3rG1BfzalekBS9roKqFWvajQPkKL9W1iXFkhzy+4uQubYwXKdBVj4zwTxmqWBT/zv+6Jf5SS0= X-Received: by 10.107.41.138 with SMTP id p132mr9353432iop.282.1504986719865; Sat, 09 Sep 2017 12:51:59 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.10.71 with HTTP; Sat, 9 Sep 2017 12:51:59 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:d5ae:f1f3:42c8:b0f7] In-Reply-To: <201709091919.v89JJE8Z075009@repo.freebsd.org> References: <201709091919.v89JJE8Z075009@repo.freebsd.org> From: Warner Losh Date: Sat, 9 Sep 2017 13:51:59 -0600 X-Google-Sender-Auth: f8VnReZjnJxe6-MmmB9lRdvuSEY Message-ID: Subject: Re: svn commit: r323371 - head/sys/conf To: Sean Bruno Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 09 Sep 2017 19:52:00 -0000 On Sat, Sep 9, 2017 at 1:19 PM, Sean Bruno wrote: > Author: sbruno > Date: Sat Sep 9 19:19:13 2017 > New Revision: 323371 > URL: https://svnweb.freebsd.org/changeset/base/323371 > > Log: > r323359 instroduced an ARMv8 only uart(4) device to the tree but placed > the driver in a place where it will be built for all targets. x86 > doesn't > have all the required build bits for this device. > > Move the uart(4) device mvebu to arm64 only. > > Modified: > head/sys/conf/files > head/sys/conf/files.arm64 > > Modified: head/sys/conf/files > ============================================================ > ================== > --- head/sys/conf/files Sat Sep 9 18:39:55 2017 (r323370) > +++ head/sys/conf/files Sat Sep 9 19:19:13 2017 (r323371) > @@ -3053,7 +3053,6 @@ dev/uart/uart_bus_puc.c optional uart puc > dev/uart/uart_bus_scc.c optional uart scc > dev/uart/uart_core.c optional uart > dev/uart/uart_dbg.c optional uart gdb > -dev/uart/uart_dev_mvebu.c optional uart uart_mvebu > dev/uart/uart_dev_ns8250.c optional uart uart_ns8250 | uart uart_snps > dev/uart/uart_dev_pl011.c optional uart pl011 > dev/uart/uart_dev_quicc.c optional uart quicc > > Modified: head/sys/conf/files.arm64 > ============================================================ > ================== > --- head/sys/conf/files.arm64 Sat Sep 9 18:39:55 2017 (r323370) > +++ head/sys/conf/files.arm64 Sat Sep 9 19:19:13 2017 (r323371) > @@ -176,6 +176,7 @@ dev/pci/pci_host_generic_fdt.c optional > pci fdt > dev/psci/psci.c optional psci > dev/psci/psci_arm64.S optional psci > dev/uart/uart_cpu_arm64.c optional uart > +dev/uart/uart_dev_mvebu.c optional uart uart_mvebu > dev/uart/uart_dev_pl011.c optional uart pl011 > dev/usb/controller/dwc_otg_hisi.c optional dwcotg fdt soc_hisi_hi6220 > dev/usb/controller/ehci_mv.c optional ehci_mv fdt > > This is a bad change since we may support running the mvebu in 32-bit mode, in which case we'd need it duplicated. There's no harm in it being in the global files file, as it won't show up automatically. Warner