From owner-freebsd-multimedia  Tue Mar 18 15:27:30 1997
Return-Path: <owner-multimedia>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id PAA10097
          for multimedia-outgoing; Tue, 18 Mar 1997 15:27:30 -0800 (PST)
Received: from Ilsa.StevesCafe.com (sc-gw.StevesCafe.com [205.168.119.191])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id PAA10090
          for <multimedia@freebsd.org>; Tue, 18 Mar 1997 15:27:26 -0800 (PST)
Received: from localhost (localhost [127.0.0.1]) by Ilsa.StevesCafe.com (8.7.5/8.6.12) with SMTP id QAA20034; Tue, 18 Mar 1997 16:27:17 -0700 (MST)
Message-Id: <199703182327.QAA20034@Ilsa.StevesCafe.com>
X-Authentication-Warning: Ilsa.StevesCafe.com: Host localhost [127.0.0.1] didn't use HELO protocol
X-Mailer: exmh version 1.6.5 12/11/95
From: Steve Passe <smp@csn.net>
To: Amancio Hasty <hasty@rah.star-gate.com>
cc: Randall Hopper <rhh@ct.picker.com>, multimedia@freebsd.org
Subject: Re: latest bt848 code 
In-reply-to: Your message of "Tue, 18 Mar 1997 15:16:38 PST."
             <199703182316.PAA16218@rah.star-gate.com> 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Tue, 18 Mar 1997 16:27:17 -0700
Sender: owner-multimedia@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

Hi,

>From a driver point of view , when the device gets open the device
>will be set to defaults values. Applications shouldn't depend
>on keeping state information between close/open. In fact thats a
>bad practice.

in general I agree, but in this case its nice if the TV comes up the
way it was last set, just like a "real" Tv does.  thats the model
I am trying to achieve.  If its a big pain to achieve don't worry
about it.

I fixed the DEV_MASK problem in open:

	bt848[BKTR_IFORM] = 0x69;
+	bktr->flags = (bktr->flags & ~METEOR_DEV_MASK) | METEOR_DEV0;

you also have a redundant:

	bktr->flags |= METEOR_OPEN;

in there.

Now xtvremote can determine the tuner type and channel that the card is
currently set to.  the color controls ( hue, etc. ) can also be accurately
read on startup, although they get reset to defaults by the 1st open.
this I can live with , now that GINPUT now accurately reflects the open state.

do you have commit privileges, or should I commit the setting of DEV_MASK
in open?  I have to commit some new tuner code anyways (once someone
confirms it works).


--
Steve Passe	| powered by
smp@csn.net	|            Symmetric MultiProcessor FreeBSD