From owner-svn-src-head@FreeBSD.ORG Sat Aug 17 14:13:46 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 1C497AD9; Sat, 17 Aug 2013 14:13:46 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 09F3629F0; Sat, 17 Aug 2013 14:13:46 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r7HEDjQZ059360; Sat, 17 Aug 2013 14:13:45 GMT (envelope-from pjd@svn.freebsd.org) Received: (from pjd@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r7HEDjfU059359; Sat, 17 Aug 2013 14:13:45 GMT (envelope-from pjd@svn.freebsd.org) Message-Id: <201308171413.r7HEDjfU059359@svn.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 17 Aug 2013 14:13:45 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r254446 - head/sys/kern X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Aug 2013 14:13:46 -0000 Author: pjd Date: Sat Aug 17 14:13:45 2013 New Revision: 254446 URL: http://svnweb.freebsd.org/changeset/base/254446 Log: In r114945 the line 'nmp = TAILQ_NEXT(mp, mnt_list);' was duplicated. Instead of just removing the duplicate, convert the loop to TAILQ_FOREACH(). Modified: head/sys/kern/vfs_subr.c Modified: head/sys/kern/vfs_subr.c ============================================================================== --- head/sys/kern/vfs_subr.c Sat Aug 17 14:09:46 2013 (r254445) +++ head/sys/kern/vfs_subr.c Sat Aug 17 14:13:45 2013 (r254446) @@ -2906,7 +2906,7 @@ vn_printf(struct vnode *vp, const char * */ DB_SHOW_COMMAND(lockedvnods, lockedvnodes) { - struct mount *mp, *nmp; + struct mount *mp; struct vnode *vp; /* @@ -2916,14 +2916,11 @@ DB_SHOW_COMMAND(lockedvnods, lockedvnode * about that. */ db_printf("Locked vnodes\n"); - for (mp = TAILQ_FIRST(&mountlist); mp != NULL; mp = nmp) { - nmp = TAILQ_NEXT(mp, mnt_list); + TAILQ_FOREACH(mp, &mountlist, mnt_list) { TAILQ_FOREACH(vp, &mp->mnt_nvnodelist, v_nmntvnodes) { - if (vp->v_type != VMARKER && - VOP_ISLOCKED(vp)) + if (vp->v_type != VMARKER && VOP_ISLOCKED(vp)) vprint("", vp); } - nmp = TAILQ_NEXT(mp, mnt_list); } }