Date: Tue, 20 Oct 2015 15:28:12 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Lars Engels <lars.engels@0x20.net> Cc: Jan Beich <jbeich@vfemail.net>, Lars Engels <lme@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r399705 - head/net-mgmt/aircrack-ng Message-ID: <566D251D429BE229A8507878@ogg.in.absolight.net> In-Reply-To: <20151020131452.GH66179@e-new.0x20.net> References: <201510191805.t9JI5mEP085148@repo.freebsd.org> <oafu-r9mo-wny@vfemail.net> <7D8DC2B6B35EA3356CFE4530@atuin.in.mat.cc> <20151020131452.GH66179@e-new.0x20.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--==========BE765D076DE07D33B7F2==========
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
+--On 20 octobre 2015 15:14:52 +0200 Lars Engels <lars.engels@0x20.net>
wrote:
| On Tue, Oct 20, 2015 at 11:26:00AM +0200, Mathieu Arnold wrote:
|>
|>
|> +--On 19 octobre 2015 20:33:35 +0200 Jan Beich <jbeich@vfemail.net>
|> wrote:
|> | Lars Engels <lme@FreeBSD.org> writes:
|> |
|> |> +INSTALL_TARGET= strip install
|> | [...]
|> |> -post-install:
|> |> - @${STRIP_CMD} ${BIN_FILES:S,^,${STAGEDIR}${PREFIX}/bin/,} \
|> |> - ${SBIN_FILES:S,^,${STAGEDIR}${PREFIX}/sbin/,}
|> |
|> | This always strips the binaries, even for WITH_DEBUG=1. The magic for
|> | INSTALL_TARGET in bsd.port.mk only works with default automake target.
|> |
|> | Index: net-mgmt/aircrack-ng/Makefile
|> | ===================================================================
|> | --- net-mgmt/aircrack-ng/Makefile (revision 399707)
|> | +++ net-mgmt/aircrack-ng/Makefile (working copy)
|> | @@ -18,7 +18,7 @@ CPE_VERSION= ${DISTVERSION:C/-.*//}
|> | CPE_UPDATE= ${DISTVERSION:C/^[^-]*$//:C/.*-//}
|> | DOS2UNIX_FILES= src/osdep/byteorder.h
|> | MAKE_ARGS= experimental=true libnl=false prefix=${PREFIX}
|> | -INSTALL_TARGET= strip install
|> | +INSTALL_TARGET= ${STRIP:S/-s/strip/} install
|> | USE_OPENSSL= yes
|> |
|> | OPTIONS_DEFINE= PCRE SQLITE
|>
|
| Thanks Jan, I didn't think about this.
|
|
|> This is harder to understand, if you don't know what STRIP is for, or
|> what it contains, it does not make a lot of sense, the previous way was
|> better, I feel.
|
| I think I'll just add a comment what Jan's solution to this problem
| does.
| The way it was before was clumy, because I had to add [S]BIN_FILES
| variables containing all (often changing) binaries.
You could also have run ${STRIP_CMD} ${STAGEDIR}${PREFIX}/*bin/* or
something similar where you did not need to maintain that list :-)
--
Mathieu Arnold
--==========BE765D076DE07D33B7F2==========
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQJ8BAEBCgBmBQJWJkFsXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IgkYP/j41ICoIQCHgoRI/65Vg1r1J
faWRnyEGy03n4PWZhXzoD2TU3Y4KhZPFwFtjjwmnuv2hEBtaEdg0DRYdM3TAv9/H
6dmYdl9EcXZBneCDs2Op4e3LTHjylICcDYrieq3al/QXWo/Dq0Xun9US+PzX/ciT
bE8N1+lx1NafDjCXgF4YVuj62sn7FDLXxbayBaVnC4Qz7hBOV66iJSKEvkM1kO/Y
7eeeOW56uWDxq281/NThOoLZFQM0gt46sQGseN4TWbOuCmH6e/cPJIC7deB2o7VP
zwTUc+DDPrMZTfT48iXnoaF8oZ8SzapaSdfOz/Q+O0RfNNZC/q7zRV1gwfcqnTL9
YUyj9X5fmZe9QcljnjosZCEsp8CxoHAYj+xFVqf5v9rJnzoQoW7YLUA9Ch0R6GeR
0Yuad7NUQU7YJOTfeX8Lo6G/ZBefT9bwBBP44SV63aZEbj94gl2nOCSdJvUumoZS
w0FAa3qDJ3a/go06mLGMUYGL2e6ckwNw9Ke74vRQrKI8TW1b0mcP8xRLsAx501vo
3erWamQLoU5Z0L0JWJqwE4csAl6R5ZhVRFE8I+2ifo+kL2qMhXQmHfMslSa/uaO/
s35vp7IzdPhCiTnYJFjmWc1sJPKclT8qsz46AWjWicv0dv8Pu0YJyifosEXq8+tU
rkeqDJegpGPGWKHx+7He
=pMIX
-----END PGP SIGNATURE-----
--==========BE765D076DE07D33B7F2==========--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?566D251D429BE229A8507878>