Date: Wed, 11 Jun 2008 00:47:42 +0200 From: Kris Kennaway <kris@FreeBSD.org> To: Alex Kozlov <spam@rm-rf.kiev.ua> Cc: ports@FreeBSD.org, cperciva@FreeBSD.org Subject: Re: INDEX build optimizations - please review Message-ID: <484F048E.3070500@FreeBSD.org> In-Reply-To: <20080610221828.GA42572@ravenloft.kiev.ua> References: <20080610221828.GA42572@ravenloft.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Alex Kozlov wrote:
> On Tue, Jun 10, 2008 at 11:52:01PM +0200, Kris Kennaway wrote:
>> Alex Kozlov wrote:
>>> On Tue, Jun 10, 2008 at 06:45:32PM +0200, Kris Kennaway wrote:
>>>> Please review and test the following patches that optimize port INDEX
>>>> builds (and as a side-effect, other recursive tree traversals). I am
>>>> particularly interested in a comparison between old and new indexes
>>>> built locally: the only diff should be in audio/festvox-hvs [1].
>>> Work on RELENG_6 only after this patch (maybe good candidate for MFC):
>> Crap! I need :u! Without it the duplicate removal will have to be
>> pushed into the perl script that collates the output, which means that
>> Colin's portsnap script may be affected.
>>
>> The patch definitely should be MFCed though. Who committed it
>> originally to HEAD?
> var.c Revision 1.161 Sat Apr 8 06:59:54 2006 UTC (2 years, 2 months ago) by fjoe
Thanks, I have emailed Max. What I think I will do is add an .if
${OSVERSION} > 6xxxxxx check around it, and keep the old perl script as
a fallback. In a couple of years when 6.3 is no longer supported we can
GC the old code.
Kris
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?484F048E.3070500>