From owner-freebsd-ports-bugs@freebsd.org Fri Apr 12 16:00:28 2019 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7E46F158028B for ; Fri, 12 Apr 2019 16:00:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id F2EA481335 for ; Fri, 12 Apr 2019 16:00:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id B0A98158028A; Fri, 12 Apr 2019 16:00:27 +0000 (UTC) Delivered-To: ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8CCA31580288 for ; Fri, 12 Apr 2019 16:00:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 25B8381330 for ; Fri, 12 Apr 2019 16:00:27 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7573C1EACD for ; Fri, 12 Apr 2019 16:00:26 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id x3CG0Qk3007299 for ; Fri, 12 Apr 2019 16:00:26 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id x3CG0Q7u007295 for ports-bugs@FreeBSD.org; Fri, 12 Apr 2019 16:00:26 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 221297] lang/go: Fix arm build Date: Fri, 12 Apr 2019 16:00:25 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: easy, needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dg@syrec.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? merge-quarterly? X-Bugzilla-Changed-Fields: cc flagtypes.name attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Apr 2019 16:00:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D221297 Dmitri Goutnik changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dg@syrec.org Attachment #203615| |maintainer-approval? Flags| | --- Comment #21 from Dmitri Goutnik --- Created attachment 203615 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D203615&action= =3Dedit Updated patch for the current lang/go - Set CGO_ENABLED=3D1 unconditionally. CGO_ENABLED already defaults to 1 on= all supported archs except ARM [1], so effectively this change just enables it = on ARM. - Set GOARM from ARCH for ARM archs. The appropriate GOARM value is suppose= d to be chosen automatically when compiling on target hardware but on FreeBSD, i= t is always set to "5" due to the code [2] from a 4 years old commit. I don't kn= ow if "FreeBSD has broken VFP support." is still true, maybe a FreeBSD/ARM exp= ert can chime in on that. QA: Builds fine in poudriere on 12a, 12i and 11a but otherwise untested - lang/= go doesn't currently build in poudriere/qemu on amd64 hosts (comment #14) and qemu-sbruno is marked as BROKEN on i386.=20 [1] https://github.com/golang/go/blob/master/src/cmd/dist/build.go#L1486 [2] https://github.com/golang/go/blob/master/src/cmd/dist/util.go#L400 --=20 You are receiving this mail because: You are the assignee for the bug.=