From owner-svn-src-all@freebsd.org Fri Oct 2 14:50:03 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CD66D42F307; Fri, 2 Oct 2020 14:50:03 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4C2tFR5727z4HsW; Fri, 2 Oct 2020 14:50:03 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 8F1A2239A8; Fri, 2 Oct 2020 14:50:03 +0000 (UTC) (envelope-from mjg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 092Eo3SU088954; Fri, 2 Oct 2020 14:50:03 GMT (envelope-from mjg@FreeBSD.org) Received: (from mjg@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 092Eo3QS088953; Fri, 2 Oct 2020 14:50:03 GMT (envelope-from mjg@FreeBSD.org) Message-Id: <202010021450.092Eo3QS088953@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: mjg set sender to mjg@FreeBSD.org using -f From: Mateusz Guzik Date: Fri, 2 Oct 2020 14:50:03 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r366363 - head/sys/kern X-SVN-Group: head X-SVN-Commit-Author: mjg X-SVN-Commit-Paths: head/sys/kern X-SVN-Commit-Revision: 366363 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 14:50:03 -0000 Author: mjg Date: Fri Oct 2 14:50:03 2020 New Revision: 366363 URL: https://svnweb.freebsd.org/changeset/base/366363 Log: cache: update the commentary for path parsing Modified: head/sys/kern/vfs_cache.c Modified: head/sys/kern/vfs_cache.c ============================================================================== --- head/sys/kern/vfs_cache.c Fri Oct 2 14:00:52 2020 (r366362) +++ head/sys/kern/vfs_cache.c Fri Oct 2 14:50:03 2020 (r366363) @@ -3948,10 +3948,10 @@ cache_fplookup_need_climb_mount(struct cache_fpl *fpl) /* * Parse the path. * - * The code is mostly copy-pasted from regular lookup, see lookup(). - * The structure is maintained along with comments for easier maintenance. - * Deduplicating the code will become feasible after fast path lookup - * becomes more feature-complete. + * The code was originally copy-pasted from regular lookup and despite + * clean ups leaves performance on the table. Any modifications here + * must take into account that in case off fallback the resulting + * nameidata state has to be compatible with the original. */ static int cache_fplookup_parse(struct cache_fpl *fpl)