From owner-freebsd-current@freebsd.org Thu Nov 19 23:42:52 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 689A9A32CEB for ; Thu, 19 Nov 2015 23:42:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-x236.google.com (mail-qg0-x236.google.com [IPv6:2607:f8b0:400d:c04::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1E1941F43 for ; Thu, 19 Nov 2015 23:42:51 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgeb1 with SMTP id b1so62775574qge.1 for ; Thu, 19 Nov 2015 15:42:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Z3czZC8dDRYylBILYvSVrhTohokGoHlc+IC/sZpUzj0=; b=hR5rNLbW61xFjcyXR+Utrta1CvspUd6xfOEHGCpRfSa+0v/gFmbiSWUuz4St4PG76H /HOyXhQfgHKDHjHR9H9pTJMQT1EFzccsI2XguJ8AxQLteIADgnY09BhN95iIb+sDE9v0 SDuwLiRgqs7a0LW705eZgZzAmwv9YmKj99j1yGw0aPdukN3ng/etaLaD1+PnwhrGVjei rGvqFAHKTxZY/WgN6YHj8nn54oCdusehqW7H4bbBhVDswEyhMHAc08n5XD8GMXBoaWJ2 2xBBDty9Domfba90rFVQzz7eCX5ynV0iIRKhBKNIH+8IBNOWGAor/UCn3YlRUouGqA+/ 0i4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Z3czZC8dDRYylBILYvSVrhTohokGoHlc+IC/sZpUzj0=; b=YKUKn6y+hiEXSYqcxjn2mGsp6EqPl4dywpZbZ5crsvzjko5fbSzrLf/MF6zu7EbeLN Lo2DAZXS/aloGffPEDwnpY0WjA4BA3/jtHdBtabWIXKpTLy8MmRhY6WJwKwGcF40W4sN N+j8V7upI9O7K7fBhjavNs6rpSPeZE9k/WvIv8LyX7qWsS+/TY+ReVZpytb6bmznic6g tt7CFKLUKjQH2ccgbYPUaVs72bfqro+9uEohBMvqt7EP35BflpXZEsgwyUd37JrmkHdw MZBhYtEjctHmYDVYfo672yYpuWuqZ7AJLtezDRWFQNYAOTwSZa+2J7Rr+vQNw8a/g9+c R6Vg== X-Gm-Message-State: ALoCoQkvryE30i1qC0mye7leKmjPhjEBDG5xJH00ROXC03WD0sJBQC1phL/M+etIIsAwcIA/qdwa MIME-Version: 1.0 X-Received: by 10.140.221.145 with SMTP id r139mr10679469qhb.94.1447976570782; Thu, 19 Nov 2015 15:42:50 -0800 (PST) Sender: wlosh@bsdimp.com Received: by 10.140.27.181 with HTTP; Thu, 19 Nov 2015 15:42:50 -0800 (PST) X-Originating-IP: [50.253.99.174] In-Reply-To: <3514235.7QMnNNElsE@ralph.baldwin.cx> References: <564E0322.8050308@freebsd.org> <3514235.7QMnNNElsE@ralph.baldwin.cx> Date: Thu, 19 Nov 2015 16:42:50 -0700 X-Google-Sender-Auth: 0EkQlZYM8k45rS0zbFViOtTM2JY Message-ID: Subject: Re: sys/modules "make clean" seems broken again From: Warner Losh To: John Baldwin Cc: FreeBSD Current , Sean Bruno Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Nov 2015 23:42:52 -0000 On Thu, Nov 19, 2015 at 11:12 AM, John Baldwin wrote: > On Thursday, November 19, 2015 09:13:06 AM Sean Bruno wrote: > > I thought I fixed this a year or two ago, but now a "make clean" in > > sys/modules seems to leave bus_if.h device_if.h and pci_if.h in the > > directory. > > > > Should I just add these to the clean targets? > > Blame Warner as his MFILES changes broke this. In particular, see r287263 > which turned off cleaning these up. I'm not sure what that broke that > caused it to be disabled. > > Your change is a gross hack though. > Yes. The reason I had to break it was that there were a few files named _if.c and _if.h in the tree that would get deleted when make clean was run in the modules. I'll take another run at fixing this. Sean's "fix" is a horrible hack. Warner