From owner-svn-src-all@freebsd.org Fri Apr 14 15:49:15 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1FA24D3D0FA; Fri, 14 Apr 2017 15:49:15 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-wr0-f176.google.com (mail-wr0-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id B464A1C55; Fri, 14 Apr 2017 15:49:14 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-wr0-f176.google.com with SMTP id l28so52746212wre.0; Fri, 14 Apr 2017 08:49:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=f9Es0/dLKhDQ7Fu/1RotCHOYaUCZ3XIEB742ihaoBVI=; b=L7OC3blNnQ7w2nx3KPX6tWp7livQWU6k44Is48oKoFmH4rPwZEKeDyM6R3ay3LV7Rk yqSua79qe2r72sZAcIXyhQYd1eBAjwg1AdHzN7A3CsZJaCbr+jgs1oK5L2oVR+hp4xyc sNWBkDtclVNxuly8E65hCmoa2AgVcCulc3u2npby4v1iwCakoIMzWHAzk9oJ6bgu4EAO dq8RgLOXPsA8HB6zxNgJ6z3aCM+s+pw2dS8zVgpkPiEXEyy5wI5rHIMYDCNyFknK++JB 8ZxhFtkap/mAGLjyNqKEmP19mwVcVDQ3pvJlVuSfNu8xN758e9vyDdujSY1nl8GGz1BU 9WKQ== X-Gm-Message-State: AN3rC/6DUZhsVygAMSjZCZeeo5cHpkmiFJXjafURFZ7EHT9+TV1E002z ZHFYjhiv3aCBNg== X-Received: by 10.223.182.155 with SMTP id j27mr7594745wre.152.1492184446133; Fri, 14 Apr 2017 08:40:46 -0700 (PDT) Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id m90sm3155392wmi.34.2017.04.14.08.40.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 Apr 2017 08:40:46 -0700 (PDT) Received: by mail-wr0-f181.google.com with SMTP id o21so52725981wrb.2; Fri, 14 Apr 2017 08:40:45 -0700 (PDT) X-Received: by 10.223.181.132 with SMTP id c4mr552425wre.178.1492184445858; Fri, 14 Apr 2017 08:40:45 -0700 (PDT) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.80.169.4 with HTTP; Fri, 14 Apr 2017 08:40:45 -0700 (PDT) In-Reply-To: <201704141516.v3EFGgK9087765@repo.freebsd.org> References: <201704141516.v3EFGgK9087765@repo.freebsd.org> From: Conrad Meyer Date: Fri, 14 Apr 2017 08:40:45 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r316851 - head/sys/x86/iommu To: Konstantin Belousov Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2017 15:49:15 -0000 On Fri, Apr 14, 2017 at 8:16 AM, Konstantin Belousov wrote: > Author: kib > Date: Fri Apr 14 15:16:41 2017 > New Revision: 316851 > URL: https://svnweb.freebsd.org/changeset/base/316851 > > Log: > Correct calculation of the entry->free_down in the invariants-checking > code. > > Reported by: maxim > Found by: PVS studio scan This was also reported by Coverity in CID 1304880 as an unused value. Coverity also reports a NULL check (l. 547) after all paths have dereferenced the pointer ("next") already in dmar_gas_alloc_region() of the same file (CID 1199386). Best, Conrad