From owner-cvs-all Fri Jan 11 14:29:49 2002 Delivered-To: cvs-all@freebsd.org Received: from mail6.speakeasy.net (mail6.speakeasy.net [216.254.0.206]) by hub.freebsd.org (Postfix) with ESMTP id 5668A37B419 for ; Fri, 11 Jan 2002 14:29:39 -0800 (PST) Received: (qmail 3979 invoked from network); 11 Jan 2002 22:29:38 -0000 Received: from unknown (HELO laptop.baldwin.cx) ([64.81.54.73]) (envelope-sender ) by mail6.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 11 Jan 2002 22:29:38 -0000 Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200201112222.g0BMMdh66532@freefall.freebsd.org> Date: Fri, 11 Jan 2002 14:29:04 -0800 (PST) From: John Baldwin To: Ian Dowse Subject: RE: cvs commit: src/sys/nfsserver nfsm_subs.h Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 11-Jan-02 Ian Dowse wrote: > iedowse 2002/01/11 14:22:39 PST > > Modified files: > sys/nfsserver nfsm_subs.h > Log: > The macro nfsm_reply() is supposed to allocate a reply in all cases, > but since the nfs cleanup, it hasn't done so in the case where > `error' is EBADRPC. Callers of this macro expect it to initialise > *mrq, and the `nfsmout' exit point expects a reply to be allocated > if error == 0. When nfsm_reply() was called with error = EBADRPC, > whatever junk was in *mrq (often a stale pointer to an old reply > mbuf) would be assumed to be a valid reply and passed to pru_sosend(), > causing a crash sooner or later. > > Fix this by allocating a reply even in the EBADRPC case like we > used to do. This bug was specific to -current. Wow, nice catch! -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message