From owner-svn-src-head@freebsd.org  Thu Jul 19 20:19:42 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6E69F1048C37;
 Thu, 19 Jul 2018 20:19:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 2148079527;
 Thu, 19 Jul 2018 20:19:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 185FE29CA; Thu, 19 Jul 2018 20:19:42 +0000 (UTC)
Date: Thu, 19 Jul 2018 20:19:42 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Devin Teske <dteske@FreeBSD.org>
Cc: Ian Lepore <ian@freebsd.org>, Michael Tuexen <tuexen@FreeBSD.org>,
 src-committers <src-committers@freebsd.org>,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6
Message-ID: <20180719201942.GA61225@FreeBSD.org>
References: <201807191933.w6JJXhof018383@repo.freebsd.org>
 <20180719195302.GA26853@FreeBSD.org>
 <1532030389.1344.9.camel@freebsd.org>
 <06745A7A-2E1C-4E48-ADCE-F42447B28A2C@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <06745A7A-2E1C-4E48-ADCE-F42447B28A2C@FreeBSD.org>
User-Agent: Mutt/1.9.5 (2018-04-13)
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jul 2018 20:19:42 -0000

On Thu, Jul 19, 2018 at 01:12:19PM -0700, Devin Teske wrote:
> > On Jul 19, 2018, at 12:59 PM, Ian Lepore <ian@freebsd.org> wrote:
> > ...
> > "usually" may be true of freebsd, but most places I've worked consider
> > the * (and & in c++) to be more associated with the type being declared
> > than with the variable name

This is often true for C++ (partially because it has both * and &), but...

> > info, not the var name. Putting the * or & with the var name leads to
> > particularly bad constructs such as
> > 
> >  int a, *b;
> > 
> > which, for maximal clarity, should be:
> > 
> >   int  a;
> >   int* b;
> 
> Are we free to prefer the former in C if that's how we've been coding in
> C for 20+ years?

I agree with Devin here: we, in FreeBSD, which is mostly coded in C, place
the star by the variable rather than its type.

./danfe