From owner-svn-src-all@FreeBSD.ORG Sat Oct 12 15:21:08 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EA35AF3D; Sat, 12 Oct 2013 15:21:07 +0000 (UTC) (envelope-from Devin.Teske@fisglobal.com) Received: from mx1.fisglobal.com (mx1.fisglobal.com [199.200.24.190]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id AFB62224D; Sat, 12 Oct 2013 15:21:07 +0000 (UTC) Received: from smtp.fisglobal.com ([10.132.206.31]) by ltcfislmsgpa03.fnfis.com (8.14.5/8.14.5) with ESMTP id r9CFL5hl020216 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT); Sat, 12 Oct 2013 10:21:05 -0500 Received: from LTCFISWMSGMB21.FNFIS.com ([169.254.1.103]) by LTCFISWMSGHT03.FNFIS.com ([10.132.206.31]) with mapi id 14.02.0309.002; Sat, 12 Oct 2013 10:21:03 -0500 From: "Teske, Devin" To: =?iso-8859-1?Q?Dag-Erling_Sm=F8rgrav?= Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Thread-Topic: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Thread-Index: AQHOx1fhW1uGCLtcyE2zUcTOTrV8Ig== Date: Sat, 12 Oct 2013 15:21:03 +0000 Message-ID: <13CA24D6AB415D428143D44749F57D720FC5B8F1@LTCFISWMSGMB21.FNFIS.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <5258F9B3.7030101@freebsd.org> <13CA24D6AB415D428143D44749F57D720FC5B547@LTCFISWMSGMB21.FNFIS.com> <86txgmr0oh.fsf@nine.des.no> In-Reply-To: <86txgmr0oh.fsf@nine.des.no> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.132.253.121] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.10.8794, 1.0.431, 0.0.0000 definitions=2013-10-12_01:2013-10-11,2013-10-12,1970-01-01 signatures=0 Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "Teske, Devin" , Nathan Whitehorn , "svn-src-head@freebsd.org" , Devin Teske X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Devin Teske List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 15:21:08 -0000 On Oct 12, 2013, at 8:03 AM, Dag-Erling Sm=F8rgrav wrote: > "Teske, Devin" writes: >> The code to replace the use of camcontrol is a a *very* complex parsing >> of the geom XML configuration data stashed in sysctl. jmg@ started the >> ball rolling on that. >=20 > You realize there is a text version as well? >=20 >> Yes. Which has been discussed at-length, you didn't need to put a >> sandbag on my back (publicly no less; thanks for that). >=20 > Umm, I think Nathan was pretty civil. You're the one who's turning this > into a catfight. >=20 Reflecting upon the thread to see if you're _right_... 1. He stated there were still some issues. [definitely civil] 2. "I am surprised you committed it especially to stable/10, before those issues were resolved." [civil? or inflammatory?] 3. "I'm also not sure if people can review their own patches." [misundersta= nding] 4. "Installer regressions are very easy to introduce and very problematic when created." [statements like that invariably lead people to believe he v= iews the commit as a regression -- I explained in a follow-up that it is not a r= egression] 5. "Real review for installer changes is thus especially important this lat= e in the release cycle." [I read this invariably as he views that the commit did not= go through "Real review", but again... there is no regression and it's purely = value- add] 6. "Do you have any plans to fix these issues in the very near future?" [de= finitely civil] What got me ralled up was #'s 2, 4, and 5. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.