From owner-freebsd-current@FreeBSD.ORG Mon Feb 4 10:45:21 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D07EE16A417 for ; Mon, 4 Feb 2008 10:45:21 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: from rv-out-0910.google.com (rv-out-0910.google.com [209.85.198.185]) by mx1.freebsd.org (Postfix) with ESMTP id 9CFEE13C458 for ; Mon, 4 Feb 2008 10:45:21 +0000 (UTC) (envelope-from ndenev@gmail.com) Received: by rv-out-0910.google.com with SMTP id g13so1609374rvb.43 for ; Mon, 04 Feb 2008 02:45:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=kff7wSG4jQCcGwlS+ugYhcupH4VpP7oUgUukX8kUO+w=; b=c6TzQMR3/Vdh/ZkufPZCsK9DmWfoUZ9YX7sFwtYFiUDS91+KdB4OhQwwBiVPeglh3E8h1iOfnaQuaT8QfdRmsz1DKW2w6zmgfzoqZLl1YN4UccNKUF2IjFJIPpXRpzuwIAiyfK7q4Ab4IKHOGLIlXK5yBO7U1CfpMG6MZzZfBTk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=WWY+xBNXFlyy2bb30W+yy/uSEEKWejh1uqQXmwvcqBXj1zjGxJD3rmZhVTrGdtAsuzJR3V5d3diWcu4k0QQiXslRYuDv3NhBxT+XrYPS33BAz5jO8VGo1WHX1vg9tmMNSAcc0K5FgRyJONk1PlzQsuJXmK4TEmoy7ptnQC9pTMo= Received: by 10.140.164.1 with SMTP id m1mr4625385rve.69.1202121920988; Mon, 04 Feb 2008 02:45:20 -0800 (PST) Received: by 10.141.170.18 with HTTP; Mon, 4 Feb 2008 02:45:20 -0800 (PST) Message-ID: <2e77fc10802040245u5452f63dq905b849a92cd7f9b@mail.gmail.com> Date: Mon, 4 Feb 2008 12:45:20 +0200 From: "Niki Denev" Sender: ndenev@gmail.com To: "Simun Mikecin" In-Reply-To: <64392.39143.qm@web36608.mail.mud.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2e77fc10802040214n5f0141c0gdd76d74b67904a83@mail.gmail.com> <64392.39143.qm@web36608.mail.mud.yahoo.com> X-Google-Sender-Auth: 583f43027e2b9adb Cc: freebsd-current@freebsd.org Subject: Re: bin/119976: [patch] Add ZFS support to gpt(8) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Feb 2008 10:45:21 -0000 On Feb 4, 2008 12:23 PM, Simun Mikecin wrote: > > --- Niki Denev wrote: > > http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/119976 > > > > I'm running here with similar patch and it works ok. > > > > But the changes to migrate.c in the PR's patch will probably won't do anything > > because FS_ZFS is not defined in /usr/include/sys/disklabel.h > > > > There was some discussion about adding it : > > http://readlist.com/lists/freebsd.org/freebsd-current/8/44907.html > > FS_ZFS *is* defined in v.110 of disklabel.h which is commited to 8-CURRENT (which is the version > that this PR is refering to). > Sorry, I missed that. The patch is complete in that case, and it would be good to support ZFS natively with gpt, gpart seems to support it already : # gpart show da0 => 34 2929686461 da0 GPT (1.5TB) 34 128 1 freebsd-boot (65.5KB) 162 104857600 2 freebsd-ufs (53.7GB) 104857762 16777216 3 freebsd-swap (8.6GB) 121634978 2808051517 4 freebsd-zfs (1.4TB) # gpt -r show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 104857600 2 GPT part - FreeBSD UFS/UFS2 104857762 16777216 3 GPT part - FreeBSD swap 121634978 2808051517 4 GPT part - 516e7cba-6ecf-11d6-8ff8-00022d09712b 2929686495 32 Sec GPT table 2929686527 1 Sec GPT header WITH_PATCHED_GPT : # gpt-zfs -r show da0 start size index contents 0 1 PMBR 1 1 Pri GPT header 2 32 Pri GPT table 34 128 1 GPT part - FreeBSD boot 162 104857600 2 GPT part - FreeBSD UFS/UFS2 104857762 16777216 3 GPT part - FreeBSD swap 121634978 2808051517 4 GPT part - FreeBSD ZFS 2929686495 32 Sec GPT table 2929686527 1 Sec GPT header --Niki