Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 Nov 2015 09:18:54 +0100
From:      Hans Petter Selasky <hps@selasky.org>
To:        cem@FreeBSD.org
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r290711 - head/sys/ofed/drivers/infiniband/core
Message-ID:  <56459CEE.4090007@selasky.org>
In-Reply-To: <CAG6CVpWKsa3SwX27JpxBeQDikeDWJXyUGWG8sS=9DvzbML9xcA@mail.gmail.com>
References:  <201511121012.tACACKTI075143@repo.freebsd.org> <CAG6CVpWKsa3SwX27JpxBeQDikeDWJXyUGWG8sS=9DvzbML9xcA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Hi,

On 11/12/15 18:17, Conrad Meyer wrote:
> These should cast through (u)intptr_t rather than unsigned long.
>

This is Linux code, and they use "unsigned long" for pointer casts 
everywhere, trying to not break their style.

BTW: I added to linux_compat.c:

CTASSERT(sizeof(unsigned long) == sizeof(uintptr_t));

And it survived my "tinderbox" build and I was surprised!

--HPS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?56459CEE.4090007>