From owner-cvs-all Thu Feb 13 0:25:37 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0921F37B401; Thu, 13 Feb 2003 00:25:36 -0800 (PST) Received: from gvr.gvr.org (gvr.gvr.org [212.61.40.17]) by mx1.FreeBSD.org (Postfix) with ESMTP id F169343FB1; Thu, 13 Feb 2003 00:25:34 -0800 (PST) (envelope-from guido@gvr.org) Received: by gvr.gvr.org (Postfix, from userid 657) id AE10C1B; Thu, 13 Feb 2003 09:25:33 +0100 (CET) Date: Thu, 13 Feb 2003 09:25:33 +0100 From: Guido van Rooij To: Jeffrey Hsu Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c Message-ID: <20030213082533.GA37720@gvr.gvr.org> References: <20030212130057.GA27427@gvr.gvr.org> <0HA700J3HMX8MM@mta6.snfc21.pbi.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0HA700J3HMX8MM@mta6.snfc21.pbi.net> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Feb 12, 2003 at 11:20:31AM -0800, Jeffrey Hsu wrote: > > > Properly document that syncache timer processing requires an > > > exclusive TCP protocol lock. > > > > This seems like a strange way of telling us you need a write-lock instead > > of a read lock... > > > > -Guido > > A write lock is an exclusive lock. (A read lock is a shared lock.) > Since INP_INFO_RLOCK() and INP_INFO_WLOCK() are both currently > defined to be the same mutex lock, this commit doesn't change anything > other than documenting for future reference when shared access can occur > and when exclusive access is required. Argh..I misread TCP protocol lock as TCP protocol hack..pfff. -Guido To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message