Date: Sat, 14 Feb 2015 06:23:09 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197582] games/assaultcube: convert to option helpers and dependency fixes Message-ID: <bug-197582-13-fWiNOBRd8p@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-197582-13@https.bugs.freebsd.org/bugzilla/> References: <bug-197582-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=197582 --- Comment #9 from Jan Beich <jbeich@FreeBSD.org> --- > - Add patch for source/src/bot/bot_waypoint.cpp file to fix "invalid source encoding" warning This piece can probably go in separately but there're more warnings with clang 3.6 or gcc 4.9 + -O3. At least one of them proved fatal for games/cube (see bug 197604). $ make -C games/assaultcube entities.cpp:69:18: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(!&mmi) continue; ~ ^~~ entities.cpp:227:21: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(&mmi && mmi.h) ^~~ ~~ entities.cpp:296:9: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(&is) ~~ ^~ entities.cpp:631:21: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(&mmi && mmi.h) clipents++; ^~~ ~~ 4 warnings generated. physics.cpp:134:18: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(!&mmi || !mmi.h) continue; ~ ^~~ 1 warning generated. server.cpp:2183:139: warning: address of array 'v->action->desc' will always evaluate to 'true' [-Wpointer-bool-conversion] ...clients[v->owner]->name, v->action && v->action->desc ? v->action->desc : "[... ~~ ~~~~~~~~~~~^~~~ server.cpp:2190:152: warning: address of array 'v->action->desc' will always evaluate to 'true' [-Wpointer-bool-conversion] ...clients[v->owner]->name, v->action && v->action->desc ? v->action->desc : "[... ~~ ~~~~~~~~~~~^~~~ server.cpp:3460:56: warning: address of array 'vi->text' will always evaluate to 'true' [-Wpointer-bool-conversion] char *vmap = newstring(vi->text ? behindpath(vi-... ~~~~^~~~ ~ 3 warnings generated. weapon.cpp:338:10: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(!&mmi || !mmi.h) return false; ~ ^~~ 1 warning generated. zip.cpp:557:8: warning: variable 'target' is used uninitialized whenever '&&' condition is false [-Wsometimes-uninitialized] if(s->open(a, f) && (target = fopen(fname, "wb"))) ^~~~~~~~~~~~~ zip.cpp:565:8: note: uninitialized use occurs here if(target) fclose(target); ^~~~~~ zip.cpp:557:8: note: remove the '&&' if its condition is always true if(s->open(a, f) && (target = fopen(fname, "wb"))) ^~~~~~~~~~~~~~~~ zip.cpp:553:17: note: initialize the variable 'target' to silence this warning FILE *target; ^ = NULL 1 warning generated. bot/bot_util.cpp:194:16: warning: reference cannot be bound to dereferenced null pointer in well-defined C++ code; pointer may be assumed to always convert to true [-Wundefined-bool-conversion] if(!&mmi || !mmi.h) continue; ~ ^~~ 1 warning generated. server.cpp:2183:139: warning: address of array 'v->action->desc' will always evaluate to 'true' [-Wpointer-bool-conversion] ...clients[v->owner]->name, v->action && v->action->desc ? v->action->desc : "[... ~~ ~~~~~~~~~~~^~~~ server.cpp:2190:152: warning: address of array 'v->action->desc' will always evaluate to 'true' [-Wpointer-bool-conversion] ...clients[v->owner]->name, v->action && v->action->desc ? v->action->desc : "[... ~~ ~~~~~~~~~~~^~~~ server.cpp:3460:56: warning: address of array 'vi->text' will always evaluate to 'true' [-Wpointer-bool-conversion] char *vmap = newstring(vi->text ? behindpath(vi-... ~~~~^~~~ ~ 3 warnings generated. crypto.cpp: In member function 'void ecjacobian::normalize()': crypto.cpp:308:33: warning: array subscript is above array bounds [-Warray-bounds] digit tmp = x.digits[i+dig+1]; ^ crypto.cpp:308:33: warning: array subscript is above array bounds [-Warray-bounds] digit tmp = x.digits[i+dig+1]; ^ crypto.cpp: In member function 'void ecjacobian::normalize()': crypto.cpp:308:33: warning: array subscript is above array bounds [-Warray-bounds] digit tmp = x.digits[i+dig+1]; ^ crypto.cpp:308:33: warning: array subscript is above array bounds [-Warray-bounds] digit tmp = x.digits[i+dig+1]; ^ In file included from rendermodel.cpp:7:0: tristrip.h: In member function 'void vertmodel::mesh::genstrips()': tristrip.h:213:62: warning: array subscript is below array bounds [-Warray-bounds] to = findedge(first, triangles[cur], first.v[from]); ^ -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-197582-13-fWiNOBRd8p>