From owner-freebsd-net@freebsd.org Mon Aug 17 23:10:31 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C28FA9BC6AC for ; Mon, 17 Aug 2015 23:10:31 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "anubis.delphij.net", Issuer "StartCom Class 1 Primary Intermediate Server CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id AC6E21387; Mon, 17 Aug 2015 23:10:31 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from zeta.ixsystems.com (unknown [12.229.62.2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by anubis.delphij.net (Postfix) with ESMTPSA id 0A9371232A; Mon, 17 Aug 2015 16:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=delphij.net; s=anubis; t=1439853031; x=1439867431; bh=wl5LkbfYvL6NJtUF8LIbczHnnQVB+tEYHiu45S9lPTA=; h=Reply-To:To:Cc:From:Subject:Date; b=PVmEYcVYH/bddyMgeFxYAgCZCIZW4HE0ft6MVH8Imh3ifkcodLDAUwZK1tuxsCsXj esJDFsRdh2NAGuXNEzlJ+waful1xBRuz4Tku3kbKlOIlCNAVgyTR/ekKEheJNzYbee Ue258xmMEP8Pe1QlWb8FgR8iWlmcXsM8CyClj7DY= Reply-To: d@delphij.net To: "Alexander V. Chernikov" Cc: "freebsd-net@freebsd.org" From: Xin Li Subject: Panic with recent -CURRENT X-Enigmail-Draft-Status: N1110 Organization: The FreeBSD Project Message-ID: <55D269E1.8000307@delphij.net> Date: Mon, 17 Aug 2015 16:10:25 -0700 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ucXQOKKobDgKJXKsH1AjVk26qCXpwfMjd" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Aug 2015 23:10:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ucXQOKKobDgKJXKsH1AjVk26qCXpwfMjd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Alexander, I'm seeing the following backtrace with kernel trap 12 at fault address of 0xf4, and the backtrace is: arpintr() at arpintr+0x85e netisr_dispatch_src() at netisr_dispatch_src+0x61 I have then read the if_ether.c as of r286525. In line 611, la is initialized as NULL; In line 751, the test ifp->if_addrlen !=3D ah->ar_hln takes the true path= , then we would reach line 752: LLE_WUNLOCK(la); And that would cause the panic. Take a more closer look, it seems that we can't reach 'match:' with a known llentry and can assert la =3D=3D NULL in line 752. The unlock seem= s to be unneeded there and should be removed. Do the following patch look sane to you? Index: sys/netinet/if_ether.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/netinet/if_ether.c (revision 286847) +++ sys/netinet/if_ether.c (working copy) @@ -749,7 +749,6 @@ match: } if (ifp->if_addrlen !=3D ah->ar_hln) { - LLE_WUNLOCK(la); ARP_LOG(LOG_WARNING, "from %*D: addr len: new %d, " "i/f %d (ignored)\n", ifp->if_addrlen, (u_char *) ar_sha(ah), ":", ah->ar_hln, Cheers, --=20 Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die --ucXQOKKobDgKJXKsH1AjVk26qCXpwfMjd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.1.7 (FreeBSD) iQIcBAEBCgAGBQJV0mnmAAoJEJW2GBstM+nsV+8P/3pCS7xDQc9u0dyS4PafYAPf l3Eibhlr62ppO88gadPo/FJlQRGQV08zIdE8pzx0Ewb+aa4LJpLAWF3G6fKmcnXS FSv/iBr3yBCYBxhm5fCTzsXEtt61yKtXQWR0dyFLjMJ0xc6m9Gm0L6LXdMNn2y9W 2VX32h8IygB2ihM4X2PtjR/r/WLFAWND6Jch22loIsoyGHy46iUxLkc4rPO1S6O5 25If8Qivp9RvBuPztIqn4Ak1FHlcy1tpdbt32T3N2TUP0A/uenJCNxxmVCH5fDa6 jZ/5VoQTLuT582e6HgK3NW417sj5Ue9h24bj5p1i5fOvGyZrSZ9JPyGy0qVQpzrl wxq39nRWQdt3hamitypllB+f0VSo823NaQdJAvpq6aiBVklummCPl4/dD7lW14Vd zpdo8diIxtdzNdriIpYJSg9pesbhlV9xcYZKWEZoiOKlK7Ruvri7gfq1uOXQTiFM CfXBbLXKIEXoyGqLJvywTAglOvnNiCQmVlgWonfRyKv54XnDGpj1yWhKJmQdrbeJ vWenmXGILhPL0uB3D/jT8Xol3v6c49SRT9rZfj/fCaCp7nvJXtkQOHlwiY4IdhwJ midKQDKd6cB2kur6MPMmW27P8e6kblB+dDe3iMK+TWZcWi/m7F3LYORAwncz88Hf uDK4O37QuoLf3sV6MK2S =m6Ld -----END PGP SIGNATURE----- --ucXQOKKobDgKJXKsH1AjVk26qCXpwfMjd--