From owner-freebsd-net  Sun Feb  3 17:37:20 2002
Delivered-To: freebsd-net@freebsd.org
Received: from patrocles.silby.com (d45.as3.nwbl0.wi.voyager.net [169.207.92.173])
	by hub.freebsd.org (Postfix) with ESMTP id 988A937B421
	for <freebsd-net@FreeBSD.ORG>; Sun,  3 Feb 2002 17:37:15 -0800 (PST)
Received: from localhost (silby@localhost)
	by patrocles.silby.com (8.11.6/8.11.6) with ESMTP id g13JeqX12958;
	Sun, 3 Feb 2002 19:40:52 GMT
	(envelope-from silby@silby.com)
X-Authentication-Warning: patrocles.silby.com: silby owned process doing -bs
Date: Sun, 3 Feb 2002 19:40:52 +0000 (GMT)
From: Mike Silbersack <silby@silby.com>
To: Luigi Rizzo <rizzo@icir.org>
Cc: freebsd-net@FreeBSD.ORG
Subject: Re: [patch] removal of mbuf allocation failure messages from if_fxp
In-Reply-To: <20020203171345.A77071@iguana.icir.org>
Message-ID: <20020203194010.D12953-100000@patrocles.silby.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org


Heh, I tend to diff in the wrong order a lot.  I'll go ahead and get it
committed then.

Mike "Silby" Silbersack

On Sun, 3 Feb 2002, Luigi Rizzo wrote:

> looks correct (apart from having to use patch -r to apply it...)
>
> 	cheers
> 	luigi
>
> On Sun, Feb 03, 2002 at 07:03:20PM +0000, Mike Silbersack wrote:
> > Luigi, does this patch look good?  AFAIK, the code you added should handle
> > printing errors in these two cases; is that correct?
> >
> > Thanks,
> >
> > Mike "Silby" Silbersack
>
> > --- if_fxp.c	Sun Feb  3 19:01:14 2002
> > +++ if_fxp.c.old	Sun Feb  3 18:59:55 2002
> > @@ -1836,6 +1836,8 @@
> >  	if (m != NULL) {
> >  		MCLGET(m, M_DONTWAIT);
> >  		if ((m->m_flags & M_EXT) == 0) {
> > +			device_printf(sc->dev,
> > +			    "cluster allocation failed, packet dropped!\n");
> >  			m_freem(m);
> >  			if (oldm == NULL)
> >  				return 1;
> > @@ -1843,6 +1845,8 @@
> >  			m->m_data = m->m_ext.ext_buf;
> >  		}
> >  	} else {
> > +		device_printf(sc->dev,
> > +		    "mbuf allocation failed, packet dropped!\n");
> >  		if (oldm == NULL)
> >  			return 1;
> >  		m = oldm;
>
>


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message