From owner-dev-commits-src-all@freebsd.org Sat Jun 19 16:22:25 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8F78F65CA97; Sat, 19 Jun 2021 16:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G6h013ckNz4Rs4; Sat, 19 Jun 2021 16:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 6559C19998; Sat, 19 Jun 2021 16:22:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 15JGMPKQ059791; Sat, 19 Jun 2021 16:22:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 15JGMPOT059790; Sat, 19 Jun 2021 16:22:25 GMT (envelope-from git) Date: Sat, 19 Jun 2021 16:22:25 GMT Message-Id: <202106191622.15JGMPOT059790@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lutz Donnerhacke Subject: git: 3fd20a79e7b5 - main - libalias: Stats are unsigned MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: donner X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3fd20a79e7b55d135bbc5fa197980fe0e9ee0f14 Auto-Submitted: auto-generated X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jun 2021 16:22:25 -0000 The branch main has been updated by donner: URL: https://cgit.FreeBSD.org/src/commit/?id=3fd20a79e7b55d135bbc5fa197980fe0e9ee0f14 commit 3fd20a79e7b55d135bbc5fa197980fe0e9ee0f14 Author: Lutz Donnerhacke AuthorDate: 2021-05-31 22:08:24 +0000 Commit: Lutz Donnerhacke CommitDate: 2021-06-19 16:21:17 +0000 libalias: Stats are unsigned Stats counters are used as unsigned valued (i.e. printf("%u")) but are defined as signed int. This causes trouble later, so fix it early. MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D30587 --- sys/netinet/libalias/alias_local.h | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sys/netinet/libalias/alias_local.h b/sys/netinet/libalias/alias_local.h index fcdaa1690470..8e2fe88fe620 100644 --- a/sys/netinet/libalias/alias_local.h +++ b/sys/netinet/libalias/alias_local.h @@ -97,14 +97,14 @@ struct libalias { /* HouseKeeping */ TAILQ_HEAD (, alias_link) checkExpire; /* Link statistics */ - int icmpLinkCount; - int udpLinkCount; - int tcpLinkCount; - int pptpLinkCount; - int protoLinkCount; - int fragmentIdLinkCount; - int fragmentPtrLinkCount; - int sockCount; + unsigned int icmpLinkCount; + unsigned int udpLinkCount; + unsigned int tcpLinkCount; + unsigned int pptpLinkCount; + unsigned int protoLinkCount; + unsigned int fragmentIdLinkCount; + unsigned int fragmentPtrLinkCount; + unsigned int sockCount; /* System time in seconds for current packet */ int timeStamp; /* If equal to zero, DeleteLink()