Date: Fri, 29 Apr 2011 09:09:34 +0200 From: Bernhard Schmidt <bschmidt@freebsd.org> To: Kevin Lo <kevlo@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Arthur Hartwig <a_hartwig@fastmaildot.fm> Subject: Re: svn commit: r221199 - head/sys/dev/usb/wlan Message-ID: <201104290909.34920.bschmidt@freebsd.org> In-Reply-To: <201104290628.p3T6SUV5086524@svn.freebsd.org> References: <201104290628.p3T6SUV5086524@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday, April 29, 2011 08:28:30 Kevin Lo wrote: > Author: kevlo > Date: Fri Apr 29 06:28:29 2011 > New Revision: 221199 > URL: http://svn.freebsd.org/changeset/base/221199 > > Log: > Guard against default ni_chan > > PR: kern/144642 > Submitted by: Arthur Hartwig <a_hartwig at fastmaildot fm> > > Modified: > head/sys/dev/usb/wlan/if_rum.c This seems about right, but.. did anyone ever verify that any beacons get sent? and if so are the information included correct? If the call fails due to the channel not yet being set, no further attempt to setup the beacons are made. This might be quite harmless for IBSS as long as other nodes are sending beacons. But for AP mode it is rather critical. There also seem to be at least one missing backcall, iv_update_beacon, this should ensure that beacons contain updated information, eg. node's powersafe states. It can also be used to ensure the beacon is setup. Any takers? :) -- Bernhard
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104290909.34920.bschmidt>