From owner-svn-src-all@freebsd.org Wed Oct 14 16:30:48 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 45EFFA13166; Wed, 14 Oct 2015 16:30:48 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DF5321016; Wed, 14 Oct 2015 16:30:47 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wijp11 with SMTP id p11so1888443wij.0; Wed, 14 Oct 2015 09:30:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ylZ6AD7l0l4yzxKNujuqVk1Kl2mH6EmL0F0nEJmGaxc=; b=Cfv2VB3kuoyh+qJisQRV4bAlXFynrRhGZhLinE/vz/US+Ma0NyOB33OH3hn1S1+IPN xZSGzfc2I1hhkTf7NJTK8MGdjpMKjpUTa9fNEPv3L8d+dUmvG6lRPUfqt32CPwRGE/eR aNA17ssGviuHddobZOH/ggJloETeNPl8v424Xmyx2PqUI+ASWFDreNwfZuhLUTVJInvy U6M639JKUa3NVj+DYQW60w7IHTqTXQ6UM3ls3n6wrjm9S7O9KLACEMzYSVK1Kv6+Kn+I xBjfEmvQOIX574D25J84p3ZYD4mRkMA72K3yuiFN49n4w+LFCpJy/TaZ3jHL0B+1Thvf 3S6g== X-Received: by 10.194.242.167 with SMTP id wr7mr5210958wjc.27.1444840246342; Wed, 14 Oct 2015 09:30:46 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id ka10sm11006509wjc.30.2015.10.14.09.30.45 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Oct 2015 09:30:45 -0700 (PDT) Sender: Baptiste Daroussin Date: Wed, 14 Oct 2015 18:30:43 +0200 From: Baptiste Daroussin To: Kristof Provost Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289316 - in head/sys: net netpfil/pf Message-ID: <20151014163043.GJ55137@ivaldir.etoilebsd.net> References: <201510141621.t9EGLfas015240@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="enLffk0M6cffIOOh" Content-Disposition: inline In-Reply-To: <201510141621.t9EGLfas015240@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 16:30:48 -0000 --enLffk0M6cffIOOh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 14, 2015 at 04:21:41PM +0000, Kristof Provost wrote: > Author: kp > Date: Wed Oct 14 16:21:41 2015 > New Revision: 289316 > URL: https://svnweb.freebsd.org/changeset/base/289316 >=20 > Log: > pf: Fix TSO issues > =20 > In certain configurations (mostly but not exclusively as a VM on Xen) pf > produced packets with an invalid TCP checksum. > =20 > The problem was that pf could only handle packets with a full checksum.= The > FreeBSD IP stack produces TCP packets with a pseudo-header checksum (on= ly > addresses, length and protocol). > Certain network interfaces expect to see the pseudo-header checksum, so= they > end up producing packets with invalid checksums. > =20 > To fix this stop calculating the full checksum and teach pf to only upd= ate TCP > checksums if TSO is disabled or the change affects the pseudo-header ch= ecksum. > =20 > PR: 154428, 193579, 198868 > Reviewed by: sbruno > MFC after: 1 week > Relnotes: yes > Sponsored by: RootBSD > Differential Revision: https://reviews.freebsd.org/D3779 >=20 Excellent! do you think it would be possible to get an errata on 10.2? that would be useful for every instance of freebsd running on cloudish stuff! Best regards, Bapt --enLffk0M6cffIOOh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYegzMACgkQ8kTtMUmk6EzZnQCeNipmWR2fVd67kiuOI8/mAWWY TzEAn2K98Dm1KXczy2eSqDRY/ZuHRfiq =wyhp -----END PGP SIGNATURE----- --enLffk0M6cffIOOh--