From owner-cvs-all Sat Jan 19 3:18:11 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id 1A27D37B405; Sat, 19 Jan 2002 03:18:07 -0800 (PST) Received: (from ache@localhost) by nagual.pp.ru (8.11.6/8.11.6) id g0JBHvM08044; Sat, 19 Jan 2002 14:17:57 +0300 (MSK) (envelope-from ache) Date: Sat, 19 Jan 2002 14:17:56 +0300 From: "Andrey A. Chernov" To: Mark Murray Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libpam/modules/pam_opie pam_opie.c Message-ID: <20020119111755.GA7979@nagual.pp.ru> References: <20020119101802.GC7243@nagual.pp.ru> <200201191053.g0JAr5t20383@grimreaper.grondar.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201191053.g0JAr5t20383@grimreaper.grondar.org> User-Agent: Mutt/1.3.24i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sat, Jan 19, 2002 at 10:53:05 +0000, Mark Murray wrote: > > I.e. I try to make working OPIE despite all compexity and obstacles comes > > from PAM. > > Fair enough, but you are leaving footprints in PAM. Please tread slightly > more carefully. Other changes, in pam_unix, is obvious, I made them while learning how this whole thing works, they are: srandomdev() -> arc4random() (srandomdev() is not for libraries) and missing check, if password expire while we check it (see original login.c or ftpd.c code). It can happens when user answer login propmt and then whole process is suspended, f.e. due to networking delay for NIS or some other, probably evil made delay. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message