From owner-cvs-src@FreeBSD.ORG Mon Jul 7 20:52:18 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 28ED3106568D for ; Mon, 7 Jul 2008 20:52:18 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from QMTA02.westchester.pa.mail.comcast.net (qmta02.westchester.pa.mail.comcast.net [76.96.62.24]) by mx1.freebsd.org (Postfix) with ESMTP id D4B828FC19 for ; Mon, 7 Jul 2008 20:52:16 +0000 (UTC) (envelope-from cokane@freebsd.org) Received: from OMTA13.westchester.pa.mail.comcast.net ([76.96.62.52]) by QMTA02.westchester.pa.mail.comcast.net with comcast id n72C1Z00E17dt5G520AP00; Mon, 07 Jul 2008 20:36:15 +0000 Received: from mail.cokane.org ([24.60.133.163]) by OMTA13.westchester.pa.mail.comcast.net with comcast id n8c61Z00M3Xh0XL3Z8c7mL; Mon, 07 Jul 2008 20:36:07 +0000 X-Authority-Analysis: v=1.0 c=1 a=_pt4sbRT5VgA:10 a=FlGvKgjM4cMA:10 a=FjLX5bMpWZx6vG2YXgAA:9 a=qIEGCmxHv1l3gyY8k8YA:7 a=_rBdrDNosyj_dOXQVT2fQl9LhyIA:4 a=SV7veod9ZcQA:10 a=LY0hPdMaydYA:10 a=emgfJcshdMYX0hdZIVwA:9 a=HsCAe0AIw1nUOwZbmjEqyoCSeg4A:4 a=rPt6xJ-oxjAA:10 Received: by mail.cokane.org (Postfix, from userid 103) id C98FD1DB2FA; Mon, 7 Jul 2008 16:36:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.1.8-gr1 (2007-02-13) on discordia X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.8-gr1 Received: from [172.20.1.3] (erwin.int.cokane.org [172.20.1.3]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.cokane.org (Postfix) with ESMTP id 7AE9F1DB2F9; Mon, 7 Jul 2008 16:36:01 -0400 (EDT) From: Coleman Kane To: Alfred Perlstein In-Reply-To: <20080707195209.GD95574@elvis.mu.org> References: <200807032326.m63NQCdW044654@repoman.freebsd.org> <20080707195209.GD95574@elvis.mu.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-sOl5lP5nr3dfx4pSXnJp" Organization: FreeBSD Project Date: Mon, 07 Jul 2008 16:33:41 -0400 Message-Id: <1215462821.2033.17.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 FreeBSD GNOME Team Port Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Ed Maste , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jul 2008 20:52:18 -0000 --=-sOl5lP5nr3dfx4pSXnJp Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2008-07-07 at 12:52 -0700, Alfred Perlstein wrote: > This really deserves a comment at each invocation of bcopy in > order to prevent regressions by someone "fixing" it again. >=20 > -Alfred >=20 > * Ed Maste [080703 16:26] wrote: > > emaste 2008-07-03 23:26:10 UTC > >=20 > > FreeBSD src repository > >=20 > > Modified files: > > sys/kern uipc_usrreq.c=20 > > Log: > > SVN rev 180238 on 2008-07-03 23:26:10Z by emaste > > =20 > > Use bcopy instead of strlcpy in uipc_bind and unp_connect, since > > soun->sun_path isn't a null-terminated string. As UNIX(4) states, "t= he > > terminating NUL is not part of the address." Since strlcpy has to re= turn > > "the total length of the string [it] tried to create," it walks off t= he end > > of soun->sun_path looking for a \0. > > =20 > > This reverts r105332. > > =20 > > Reported by: Ryan Stone > > =20 > > Revision Changes Path > > 1.215 +4 -2 src/sys/kern/uipc_usrreq.c >=20 Hopefully people will begin to incorporate "svn blame" into their work-flows. --=20 Coleman Kane --=-sOl5lP5nr3dfx4pSXnJp Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkhyfaIACgkQcMSxQcXat5d92gCfXHwFkzXzvQBPifvjrDXXpUj4 BOQAn2qRtZ/90cKxy/TOiPxU+OTJj1ah =urgU -----END PGP SIGNATURE----- --=-sOl5lP5nr3dfx4pSXnJp--