From owner-svn-src-head@freebsd.org Sat Nov 7 19:58:00 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 324B5A2834A; Sat, 7 Nov 2015 19:58:00 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BE3AC1483; Sat, 7 Nov 2015 19:57:59 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicll6 with SMTP id ll6so48392632wic.0; Sat, 07 Nov 2015 11:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=jTXj+VdUlT8et+sHFSnIexXj1cSdM5x/UYngjb3+5r0=; b=L2O3cjKeOdeQPkCpQ5/RhJOMsphDkspBoIBH9vlc2mXvAPAMajjnD3sjOnCWTokq7C cIU8uGdWQp9GWoZn5jim6Sqz84bBDH1Mgv7MDk8HLrjRxAYzJDBj8OtnclZjjmvvN1Yo 8x/+/Ivid1TJOYIbejnKAx1AIa+m9tvp2GiHRk1Gx5dIS7oSGJuWa17IFNUNpEL4gr7l JmTBM4MQxMC7LZJrHLzGAUiyfJr1mL0rYSBpHD1FgPw/hDzxDLZf0o8wTuMpNuRXudJU Ad67NF4LIMhWnjrBVuh1Drw8LLPHg7QpvKe1jikoE2BFlBhk8NJaEyOlNLeqkbGL+HA9 0X6w== X-Received: by 10.194.90.79 with SMTP id bu15mr25318953wjb.36.1446926278199; Sat, 07 Nov 2015 11:57:58 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id 71sm5458488wmt.15.2015.11.07.11.57.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 07 Nov 2015 11:57:57 -0800 (PST) Sender: Baptiste Daroussin Date: Sat, 7 Nov 2015 20:57:55 +0100 From: Baptiste Daroussin To: Andrey Chernov Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, jasone@FreeBSD.org Subject: Re: svn commit: r290499 - head/usr.bin/localedef Message-ID: <20151107195755.GC31396@ivaldir.etoilebsd.net> References: <201511071622.tA7GMTDN099727@repo.freebsd.org> <563E2BA6.9020505@freebsd.org> <20151107165636.GA31396@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="f+W+jCU1fRNres8c" Content-Disposition: inline In-Reply-To: <20151107165636.GA31396@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 19:58:00 -0000 --f+W+jCU1fRNres8c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 07, 2015 at 05:56:36PM +0100, Baptiste Daroussin wrote: > On Sat, Nov 07, 2015 at 07:49:42PM +0300, Andrey Chernov wrote: > > On 07.11.2015 19:22, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Sat Nov 7 16:22:29 2015 > > > New Revision: 290499 > > > URL: https://svnweb.freebsd.org/changeset/base/290499 > > >=20 > > > Log: > > > Workaround an issue on i386 to unbreak the build until the real iss= ue is tracked > > > down > > > - large =3D calloc(sizeof (collate_large_t) * n, 1); > > > + large =3D malloc(sizeof (collate_large_t) * n); > > > + memset(large, 0, sizeof (collate_large_t) * n); > >=20 > > Should be calloc(n, sizeof (collate_large_t)) according to calloc usage > > and to prevent size_t overflow. Is it calloc() bug? >=20 > I have tried all combinaison with calloc before committing the workaround= , all > fails the same way on i386: > : jemalloc_arena.c:353: Failed assertion: "p[i] =3D=3D 0" >=20 > So yes I'm thinking about a calloc bug (Jason CCed) >=20 > FYI sizeof(collate_large_t) is 44 there and n is 1145 >=20 > Best regards, > Bapt Issue found by dim@ using the Address Sanitizer Guilty was me through a bug I introduced during conversion from avl(3) to tree(3). Best regards, Bapt --f+W+jCU1fRNres8c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlY+V8MACgkQ8kTtMUmk6EwnpgCgiGB4A1tY9Q86PRUMYhqNuLxP b+AAnA4pc9Fx3N6Apn8Uin4TRUuIEHhe =bois -----END PGP SIGNATURE----- --f+W+jCU1fRNres8c--