From owner-svn-src-head@freebsd.org  Sat Apr  7 22:23:14 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9F08CF8ACEB
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sat,  7 Apr 2018 22:23:14 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org
 [52.58.109.202])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 298F980CE0
 for <svn-src-head@freebsd.org>; Sat,  7 Apr 2018 22:23:13 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 41618142-3ab2-11e8-91c6-33ffc249f3e8
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound1.eu.mailhop.org (Halon) with ESMTPSA
 id 41618142-3ab2-11e8-91c6-33ffc249f3e8;
 Sat, 07 Apr 2018 22:23:12 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w37MN53j094272;
 Sat, 7 Apr 2018 16:23:05 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1523139785.89422.3.camel@freebsd.org>
Subject: Re: svn commit: r332258 - head/sys/dev/spibus
From: Ian Lepore <ian@freebsd.org>
To: "O. Hartmann" <ohartmann@walstatt.org>, Navdeep Parhar <np@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Sat, 07 Apr 2018 16:23:05 -0600
In-Reply-To: <20180408000013.1fc266c4@thor.intern.walstatt.dynvpn.de>
References: <201804072131.w37LV9fv020077@repo.freebsd.org>
 <20180408000013.1fc266c4@thor.intern.walstatt.dynvpn.de>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 07 Apr 2018 22:23:14 -0000

On Sat, 2018-04-07 at 23:59 +0200, O. Hartmann wrote:
> Am Sat, 7 Apr 2018 21:31:09 +0000 (UTC)
> Ian Lepore <ian@FreeBSD.org> schrieb:
> 
> > 
> > Author: ian
> > Date: Sat Apr  7 21:31:09 2018
> > New Revision: 332258
> > URL: https://svnweb.freebsd.org/changeset/base/332258
> > 
> > Log:
> >   Don't check for impossible NULL return from malloc(..., M_WAITOK).
> > 
> > Modified:
> >   head/sys/dev/spibus/spigen.c
> > 
> > [...]
> 
> [...]
> --- spigen.o ---
> /usr/src/sys/dev/spibus/spigen.c:327:33: error: incompatible pointer types passing
> 'uintptr_t *' (aka 'unsigned long *') to parameter of type 'uint32_t *' (aka 'unsigned
> int *') [-Werror,-Wincompatible-pointer-types] error = spibus_get_clock(dev, (uintptr_t
> *)data); ^~~~~~~~~~~~~~~~~
> 

Doh!  Sorry about that, fixed in r332259.

-- Ian