From owner-svn-src-all@freebsd.org Tue May 8 20:40:42 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D65CEFC9929 for ; Tue, 8 May 2018 20:40:42 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 772666AC8B for ; Tue, 8 May 2018 20:40:42 +0000 (UTC) (envelope-from tuexen@freebsd.org) Received: from [IPv6:2003:cd:6f1c:a300:de5:e962:eccc:cd30] (p200300CD6F1CA3000DE5E962ECCCCD30.dip0.t-ipconnect.de [IPv6:2003:cd:6f1c:a300:de5:e962:eccc:cd30]) (Authenticated sender: macmic) by mail-n.franken.de (Postfix) with ESMTPSA id 57575721E280D; Tue, 8 May 2018 22:40:34 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: svn commit: r333382 - head/sys/netinet From: Michael Tuexen In-Reply-To: <002E38ED710A92624EB727B0@triton.njm.me.uk> Date: Tue, 8 May 2018 22:40:33 +0200 Cc: svn-src-all@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <4FB5A51E-44A6-476A-9205-F075B85D56F1@freebsd.org> References: <201805081848.w48Imq8b082041@repo.freebsd.org> <002E38ED710A92624EB727B0@triton.njm.me.uk> To: "N.J. Mann" X-Mailer: Apple Mail (2.3445.6.18) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 May 2018 20:40:43 -0000 > On 8. May 2018, at 21:05, N.J. Mann wrote: >=20 > Hi, >=20 >=20 > On Tuesday, May 08, 2018 18:48:52 +0000 Michael Tuexen = wrote: >> Author: tuexen >> Date: Tue May 8 18:48:51 2018 >> New Revision: 333382 >> URL: https://svnweb.freebsd.org/changeset/base/333382 >>=20 >> Log: >> When reporting ERROR or ABORT chunks, don't use more data >> that is guaranteed to be contigous. > ^^^^^^^^^ > contiguous >=20 > [...] >> Modified: head/sys/netinet/sctputil.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/netinet/sctputil.c Tue May 8 18:25:37 2018 = (r333381) >> +++ head/sys/netinet/sctputil.c Tue May 8 18:48:51 2018 = (r333382) >> @@ -2660,6 +2660,13 @@ sctp_notify_assoc_change(uint16_t state, = struct sctp_t >> notif_len =3D (unsigned int)sizeof(struct = sctp_assoc_change); >> if (abort !=3D NULL) { >> abort_len =3D ntohs(abort->ch.chunk_length); >> + /* >> + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to = be >> + * contiguos. > ^^^^^^^^^ > contiguous >=20 > [...] >> @@ -3565,6 +3572,13 @@ sctp_notify_remote_error(struct sctp_tcb = *stcb, uint16 >> } >> if (chunk !=3D NULL) { >> chunk_len =3D ntohs(chunk->ch.chunk_length); >> + /* >> + * Only SCTP_CHUNK_BUFFER_SIZE are guaranteed to be >> + * contiguos. > ^^^^^^^^^ > contiguous >=20 Fixed in https://svnweb.freebsd.org/changeset/base/333386. Thanks for the report. Best regards Michael > Cheers, > Nick. > --=20 >=20